Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xDnsServer: Revert back to using latest Sampler #212

Merged
merged 1 commit into from Mar 20, 2021

Conversation

johlju
Copy link
Member

@johlju johlju commented Mar 20, 2021

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Mar 20, 2021
@codecov
Copy link

codecov bot commented Mar 20, 2021

Codecov Report

Merging #212 (275e95e) into main (6b8daba) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #212   +/-   ##
===================================
  Coverage    88%    88%           
===================================
  Files        16     16           
  Lines      1256   1256           
===================================
  Hits       1110   1110           
  Misses      146    146           

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit b300010 into dsccommunity:main Mar 20, 2021
@johlju johlju deleted the fix/issue-211 branch March 20, 2021 11:43
@johlju johlju removed the needs review The pull request needs a code review. label Mar 20, 2021
@Sudman1
Copy link
Contributor

Sudman1 commented Mar 20, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUILD FAILURE: xDnsServer: Cannot build the module
2 participants