Assert-Module: Outputs unnecessary verbose statements due to -ListAvailable is used each time

[johlju]

Details of the scenario you tried and the problem that is occurring

Every time when running Assert-Module and $VerbosePreference is set to 'Continue' the command outputs a lot of verbose statements depending on what module is asserted.

Steps to reproduce the problem

$VerbosePreference = 'Continue'
Assert-Module -ModuleName 'DnsServer'

Outputs

VERBOSE: Loading module from path
'C:\Windows\system32\WindowsPowerShell\v1.0\Modules\DnsServer\PS_DnsServerCache_v1.0.0.cdxml'.
VERBOSE: Loading module from path
'C:\Windows\system32\WindowsPowerShell\v1.0\Modules\DnsServer\PS_DnsServerConditionalForwarder_v1.0.0.cdxml'.
VERBOSE: Loading module from path
'C:\Windows\system32\WindowsPowerShell\v1.0\Modules\DnsServer\PS_DnsServerDiagnostics_v1.0.0.cdxml'.
VERBOSE: Loading module from path
'C:\Windows\system32\WindowsPowerShell\v1.0\Modules\DnsServer\PS_DnsServerDirectoryPartition_v1.0.0.cdxml'.
VERBOSE: Loading module from path
'C:\Windows\system32\WindowsPowerShell\v1.0\Modules\DnsServer\PS_DnsServerDsSetting_v1.0.0.cdxml'.
VERBOSE: Loading module from path

.... Removed rows for readability

VERBOSE: Loading module from path
'C:\Windows\system32\WindowsPowerShell\v1.0\Modules\DnsServer\PS_DnsServerRecursionScope_v1.0.0.cdxml'.
VERBOSE: Loading module from path
'C:\Windows\system32\WindowsPowerShell\v1.0\Modules\DnsServer\PS_DnsServerQueryResolutionPolicy_v1.0.0.cdxml'.
VERBOSE: Loading module from path
'C:\Windows\system32\WindowsPowerShell\v1.0\Modules\DnsServer\PS_DnsServerZoneTransferPolicy_v1.0.0.cdxml'.
VERBOSE: Loading module from path
'C:\Windows\system32\WindowsPowerShell\v1.0\Modules\DnsServer\PS_DnsServerPolicy_v1.0.0.cdxml'.
VERBOSE: Loading module from path
'C:\Windows\system32\WindowsPowerShell\v1.0\Modules\DnsServer\PS_DnsServerResponseRateLimiting_v1.0.0.cdxml'.
VERBOSE: Loading module from path
'C:\Windows\system32\WindowsPowerShell\v1.0\Modules\DnsServer\PS_DnsServerResponseRateLimitingExceptionlist_v1.0.0.cdxml'.
VERBOSE: Loading module from path
'C:\Windows\system32\WindowsPowerShell\v1.0\Modules\DnsServer\PS_DnsServerVirtualizationInstance_v1.0.0.cdxml'.

Expected behavior

Only show these verbose messages when the module to assert is not in the session.

Current behavior

Always shows the verbose messages even if the module is already present in the session

Suggested solution to the issue

This is due to -ListAvailable is always used.

DscResource.Common/source/Public/Assert-Module.ps1

Line 33 in 8000541

if (-not (Get-Module -Name $ModuleName -ListAvailable))

Suggest adding an evaluation if (-not (Get-Module -Name $ModuleName)) before using -ListAvailable. Using that will not output the verbose messages,.

The operating system the target node is running

Windows Server 2016

Version and build of PowerShell the target node is running

5.1

Version of the module that was used

0.10.1