-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Public Function Find-Certificate #101
Conversation
Removed unneeded characters marking headings.
Codecov Report
@@ Coverage Diff @@
## main #101 +/- ##
===================================
Coverage 91% 92%
===================================
Files 34 35 +1
Lines 599 628 +29
===================================
+ Hits 550 579 +29
Misses 49 49
|
I forgot about this. I have been working a lot lately so I haven't been able do much community work. Will try to look at this soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 5 files at r1, 1 of 1 files at r2, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @hollanjs)
tests/Unit/Public/Find-Certificate.Tests.ps1
line 154 at r4 (raw file):
It 'Should call expected mocks' { Assert-MockCalled -CommandName Test-Path -Exactly -Times 1 -Scope "context"
We can replace all these aliases with Should -Invoke -CommandName
since this repo is using Pester v5. Throughout the tests.
Suggestion:
Should -Invoke -CommandName
@hollanjs sorry for tasking so long wit this one. Just a tiny comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 4 of 5 files reviewed, all discussions resolved (waiting on @hollanjs)
tests/Unit/Public/Find-Certificate.Tests.ps1
line 154 at r4 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
We can replace all these aliases with
Should -Invoke -CommandName
since this repo is using Pester v5. Throughout the tests.
Done. I sent in a commit to fix this so we can merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r5.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @hollanjs)
Pull Request (PR) description
Moved
Find-Certificate
from a utility function in CertificateDsc.Common.psm1 to a public function in DscResource.Common.Related to CertificateDsc Issue #272
This Pull Request (PR) fixes the following issues
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
DSC Community Testing Guidelines.
This change is