Add public commands Get-PSModulePath and Get-EnvironmentVariable

[johlju]

Pull Request (PR) description

• New public commands.
  • Get-EnvironmentVariable - Get a specific environment variable from a
    specific environment variable target.
  • Get-PSModulePath - Get the the PSModulePath from one or more environment
    variable targets - Issue #103

This Pull Request (PR) fixes the following issues

• Fixes Get-PSModulePath: New command proposal #103

Task list

• Added an entry to the change log under the Unreleased section of the
  file CHANGELOG.md. Entry should say what was changed and how that
  affects users (if applicable), and reference the issue being resolved
  (if applicable).
• Documentation added/updated in README.md.
• Comment-based help added/updated for all new/changed functions.
• Localization strings added/updated in all localization files as appropriate.
• Examples appropriately added/updated.
• Unit tests added/updated. See DSC Community Testing Guidelines.
• Integration tests added/updated (where possible). See
  DSC Community Testing Guidelines.
• New/changed code adheres to DSC Community Style Guidelines.

---

This change is 

[codecov]

Codecov Report

Merging #104 (eb48057) into main (e817645) will decrease coverage by 1%.
The diff coverage is 88%.

@@         Coverage Diff         @@
##           main   #104   +/-   ##
===================================
- Coverage    92%    92%   -1%     
===================================
  Files        35     37    +2     
  Lines       628    645   +17     
===================================
+ Hits        579    594   +15     
- Misses       49     51    +2     

Impacted Files	Coverage Δ
source/Public/Get-EnvironmentVariable.ps1	60% <60%> (ø)
source/Public/Get-PSModulePath.ps1	100% <100%> (ø)

[PlagueHO]

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @johlju)

---

README.md line 723 at r1 (raw file):

Returns the environment variable PSModulePath from the specified target.
If more than one target are provided only the unique paths will be

Could this be changed to:
If more than one target is provided the return will contain all the concatenation of all unique paths from the targets.

---

source/Public/Get-PSModulePath.ps1 line 8 at r1 (raw file):

    .DESCRIPTION
        Returns the environment variable PSModulePath from the specified target.
        If more than one target are provided only the unique paths will be

See previous comment on clarification of behavior.

---

source/Public/Get-PSModulePath.ps1 line 41 at r1 (raw file):

    )

    $modulePathSession = $null

nit: I don't think (I couldn't find) a style guideline on this, but you could use (although not sure it's the most clear syntax). Will leave it up to you:

Suggestion:

    $modulePathSession = $modulePathUser = $modulePathMachine = $null

---

tests/Unit/Public/Get-PSModulePath.Tests.ps1 line 86 at r1 (raw file):

        }
    }

Nit: remove blank line.

[johlju]

Reviewable status: 3 of 6 files reviewed, 2 unresolved discussions (waiting on @PlagueHO)

---

README.md line 723 at r1 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Could this be changed to:
If more than one target is provided the return will contain all the concatenation of all unique paths from the targets.

Done.

---

source/Public/Get-PSModulePath.ps1 line 8 at r1 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

See previous comment on clarification of behavior.

Done.

---

source/Public/Get-PSModulePath.ps1 line 41 at r1 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

nit: I don't think (I couldn't find) a style guideline on this, but you could use (although not sure it's the most clear syntax). Will leave it up to you:

Done. We can do it this way too. Changed. 🙂

---

tests/Unit/Public/Get-PSModulePath.Tests.ps1 line 86 at r1 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Nit: remove blank line.

Done.

[johlju]

@PlagueHO thanks for the review! Hopefully it good to be sign-off on now. 🙂

[PlagueHO]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @johlju)