Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in Module Tests Describing Changelog Management #81

Closed
PlagueHO opened this issue Aug 8, 2020 · 0 comments · Fixed by #83
Closed

Error in Module Tests Describing Changelog Management #81

PlagueHO opened this issue Aug 8, 2020 · 0 comments · Fixed by #83
Assignees
@PlagueHO
Labels
bug The issue is a bug.

Comments

@PlagueHO
Copy link
Member

PlagueHO commented Aug 8, 2020

An unknown recent behavior change has started causing an error to occur in Tests/QA/Changelog.common.Tests.ps1 when Describing Changelog Management. This is caused in line https://github.com/dsccommunity/DscResource.Test/blob/master/tests/QA/module.tests.ps1#L26.

The fix is to stringify the parameters:

$filesChanged = &git @('diff', "$MasterCommit...$HeadCommit", '--name-only')
@PlagueHO PlagueHO added bug The issue is a bug. in progress The issue is being actively worked on by someone. labels Aug 8, 2020
@PlagueHO PlagueHO self-assigned this Aug 8, 2020
PlagueHO added a commit that referenced this issue Aug 8, 2020
@PlagueHO
Issue #81 - fix module tests
aef2f1a
@PlagueHO PlagueHO mentioned this issue Aug 8, 2020
Merged
@johlju johlju closed this as completed in #83 Aug 8, 2020
johlju pushed a commit that referenced this issue Aug 8, 2020
@PlagueHO
Fix Describing Changelog Management Module Tests - Fixes #81 (#83)
0c6d370 
- Fixed error in Tests/QA/Changelog.common.Tests.ps1 when Describing Changelog
  Management (issue #81).
- Added support for passing alternate trunk branch name through to
  Invoke-DscResourceTest.Tests.ps1 function (issue #82).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PlagueHO PlagueHO

Labels
bug The issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Describing Changelog Management Module Tests - Fixes #81 dsccommunity/DscResource.Test
2 participants
@johlju @PlagueHO