xClusterDisk: Refactored unit tests #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the unit test for this resource to use stubs and increase coverage (issue dsccommunity#74). Removed an evaluation that called Test-TargetResource in Set-TargetResource method and instead added logic so that Set-TargetResource evaluates if it should remove a disk (issue dsccommunity#90). Changed the code to be more aligned with the style guideline.
Added examples - 1-AddClusterDisk.ps1 - 2-RemoveClusterDisk.ps1 Added links to examples from README.md.
|
@johlju, |
Codecov Report
@@ Coverage Diff @@
## dev #91 +/- ##
=================================
+ Coverage 64% 70% +6%
=================================
Files 6 6
Lines 292 292
=================================
+ Hits 188 207 +19
+ Misses 104 85 -19 |
|
@bgelens Next one up. When ever you have time. I will start on the next resource tomorrow. But at least this one takes us over 70% limit so that the CodeCov check becomes green 😄 |
|
Reviewed 7 of 8 files at r1, 1 of 1 files at r2. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues:
Fixes #90
Fixes #74
Task list:
This change is