BREAKING CHANGE: xHyper-V renamed to HyperVDsc: Renamed all DSCResources, Examples, Modules and Tests where applicable

[nickgw]

Pull Request (PR) description

BREAKING CHANGE: xHyper-V renamed to HyperVDsc: Renamed all DSCResources, Examples, Modules and Tests where applicable

This Pull Request (PR) fixes the following issues

• Fixes Convert xHyper-V to HQRM standards #62

Task list

• Added an entry to the change log under the Unreleased section of the
  file CHANGELOG.md. Entry should say what was changed and how that
  affects users (if applicable), and reference the issue being resolved
  (if applicable).
• Resource documentation added/updated in README.md.
• Resource parameter descriptions added/updated in README.md, schema.mof
  and comment-based help.
• Comment-based help added/updated.
• Localization strings added/updated in all localization files as appropriate.
• Examples appropriately added/updated.
• Unit tests added/updated. See DSC Community Testing Guidelines.
• Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
• New/changed code adheres to DSC Community Style Guidelines.

---

This change is 

[codecov]

Codecov Report

Merging #194 (55e3116) into master (77822fb) will increase coverage by 9%.
The diff coverage is 83%.

@@          Coverage Diff           @@
##           master   #194    +/-   ##
======================================
+ Coverage      73%    83%    +9%     
======================================
  Files          11     11            
  Lines        1401   1435    +34     
======================================
+ Hits         1035   1200   +165     
+ Misses        366    235   -131     

Impacted Files	Coverage Δ
...ces/DSC_VMNetworkAdapter/DSC_VMNetworkAdapter.psm1	47% <50%> (ø)
...rce/Modules/HyperVDsc.Common/HyperVDsc.Common.psm1	86% <79%> (ø)
source/DSCResources/DSC_VMSwitch/DSC_VMSwitch.psm1	85% <82%> (ø)
source/DSCResources/DSC_VMHyperV/DSC_VMHyperV.psm1	85% <83%> (ø)
...ces/DSC_VhdFileDirectory/DSC_VhdFileDirectory.psm1	89% <91%> (ø)
source/DSCResources/DSC_VHD/DSC_Vhd.psm1	96% <92%> (ø)
...urces/DSC_VMHardDiskDrive/DSC_VMHardDiskDrive.psm1	89% <95%> (ø)
...ce/DSCResources/DSC_VMDvdDrive/DSC_VMDvdDrive.psm1	98% <97%> (ø)
source/DSCResources/DSC_VMHost/DSC_VMHost.psm1	100% <100%> (ø)
.../DSCResources/DSC_VMProcessor/DSC_VMProcessor.psm1	100% <100%> (ø)
... and 4 more

[nickgw]

@johlju while I've got your attention, idk if you saw this!

[johlju]

Will look at it when I have some time. 😊

[johlju]

Reviewed 3 of 7 files at r1, 84 of 85 files at r2, 4 of 4 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @nickgw)

---

azure-pipelines.yml line 178 at r3 (raw file):

              pwsh: false

          - powershell: |

Just curious, is this necessary? It is not run for Win2022 integration tests. 🤔

Code quote:

          - powershell: |
              Set-Service -Name wuauserv -StartupType Manual -Verbose
              Start-Service -name wuauserv -Verbose

---

build.yaml line 54 at r3 (raw file):

    - Publish_Release_To_GitHub
    - Publish_GitHub_Wiki_Content
    - Create_ChangeLog_GitHub_PR

This can be removed here there is a task in azure-pipelines.yml Deploy stage that runs this.

Code quote:

 Create_ChangeLog_GitHub_PR

---

tests/Integration/DSC_VMDvdDrive_remove.config.ps1 line 1 at r3 (raw file):

configuration MSFT_VMDvdDrive_Remove_Config {

We should change to:

Suggestion:

DSC_

[johlju]

@nickgw just a few tiny comments. 🙂

[nickgw]

@nickgw just a few tiny comments. 🙂
I'm not 100% on your first comment. I pulled azure-pipelines.yml from another repo that was updated more recently. I don't know if something changed concerning wuauserv in W2022 that changes that behavior.

I've updated the other two comments though.

[johlju]

Okey then I think you can safely remove the task in azure-pipelines.yml in this repo as it was not used prior. Guessing that was needed in the other repo to run a certain test.

[nickgw]

Okey then I think you can safely remove the task in azure-pipelines.yml in this repo as it was not used prior. Guessing that was needed in the other repo to run a certain test.

Removed!

[johlju]

Reviewed 2 of 2 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nickgw)

---

build.yaml line 51 at r3 (raw file):

  publish:
    - publish_module_to_gallery

It was only the task Create_ChangeLog_GitHub_PR that needed to be removed, it should look like this.

Suggestion:

  publish:
    - publish_module_to_gallery
    - Publish_Release_To_GitHub
    - Publish_GitHub_Wiki_Content

[johlju]

I updated pipeline files and added resource README files to enable Wiki documentation.
@nickgw can you rebase this when you have a chance?

[johlju]

@nickgw suggest you take azure-pipelines.yml from branch master and paste in into this PR. It will clear everything up I think.

[johlju]

You currently have the code coverage steps twice in the one in this PR. 🤔 So above suggestion might just be the easiest to fix it.. 🙂

[johlju]

Reviewed 20 of 21 files at r6, 1 of 1 files at r8.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @nickgw)

[johlju]

@nickgw awesome work on this, thank you! I waiting for the API key then I merge this.