Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JeaDsc: Fix failing build task Generate_Wiki_Content #56

Merged
merged 2 commits into from
Apr 28, 2023

Conversation

johlju
Copy link
Member

@johlju johlju commented Apr 28, 2023

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

None.

Task list

  • Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Resource documentation added/updated in comment-based help.
  • Resource parameter descriptions added/updated in comment-based help.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #56 (c031ebd) into master (7608302) will not change coverage.
The diff coverage is n/a.

❗ Current head c031ebd differs from pull request most recent head dc470bc. Consider uploading reports for the commit dc470bc to get more accurate results

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #56   +/-   ##
====================================
  Coverage      35%   35%           
====================================
  Files           5     5           
  Lines         445   445           
====================================
  Hits          160   160           
  Misses        285   285           
Impacted Files Coverage Δ
source/Classes/005.RoleCapabilitiesUtility.ps1 0% <ø> (ø)
source/Classes/005.SessionConfigurationUtility.ps1 0% <ø> (ø)
source/Classes/020.JeaRoleCapabilities.ps1 0% <ø> (ø)
source/Classes/020.JeaSessionConfiguration.ps1 0% <ø> (ø)

Copy link

@raandree raandree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@raandree
Copy link

Thanks, what was missing. I will remove this from my PR then.

@johlju
Copy link
Member Author

johlju commented Apr 28, 2023

Yes, I copied it from you. I guessed you fixed the same issue that I got here 🙂

@johlju johlju merged commit e38e2a4 into dsccommunity:master Apr 28, 2023
6 checks passed
@johlju johlju deleted the fix/wiki-build-error branch April 28, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants