Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xNewAdapterName output misleading when Adapter Not Found #209

Closed
PlagueHO opened this issue May 5, 2017 · 1 comment
Closed

xNewAdapterName output misleading when Adapter Not Found #209

PlagueHO opened this issue May 5, 2017 · 1 comment
Assignees
Labels
bug The issue is a bug. in progress The issue is being actively worked on by someone.

Comments

@PlagueHO
Copy link
Member

PlagueHO commented May 5, 2017

If the xNewAdapterName resource is used to rename an adapter using the name where an adapter with the existing or new name can't be found then a misleading error message will be shown.

@PlagueHO PlagueHO added bug The issue is a bug. in progress The issue is being actively worked on by someone. labels May 5, 2017
@PlagueHO PlagueHO self-assigned this May 5, 2017
@PlagueHO
Copy link
Member Author

PlagueHO commented May 6, 2017

@johlju, @ChrisLGardner - I've found a few more bugs in this (exposed when I extended integration tests to cover a simple rename using name only). So I've fixed those as well.

I've improved the log information as well and extended the integration and unit tests to provide better coverage of these scenarios.

The resource can now be correctly used to rename an adapter by just identifying it by name. But this isn't the primary user story that drove this. If you know the adapter name already, then renaming it isn't really that useful (but it'll work).

The primary user story that this should address is when you don't know the adapter name in the OS - you only know various parameters of the adapter (e.g. MAC Address, Driver) and therefore need to rename it so that that all other resources have a known name they can reference.

For example:

        xNetAdapterName RenameNetAdapterCluster
        {
            NewName        = 'Cluster'
            MacAddress     = '9C-D2-1E-61-B5-DA'
        }

This will work fine - but it's not really the primary purpose:

        xNetAdapterName RenameNetAdapterCluster
        {
            NewName        = 'Cluster'
            Name      = 'Ethernet 1'
        }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug. in progress The issue is being actively worked on by someone.
Projects
None yet
Development

No branches or pull requests

1 participant