Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Module Name to NetworkingDsc #290

Closed
PlagueHO opened this issue Dec 8, 2017 · 7 comments · Fixed by #330
Closed

Convert Module Name to NetworkingDsc #290

PlagueHO opened this issue Dec 8, 2017 · 7 comments · Fixed by #330
Assignees
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.
Milestone

Comments

@PlagueHO
Copy link
Member

PlagueHO commented Dec 8, 2017

As per recent DSC Resource Naming guidelines changes:
https://github.com/PowerShell/DscResources/blob/master/Naming.md

@PlagueHO PlagueHO added breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Dec 8, 2017
@PlagueHO PlagueHO added this to the NetworkingDsc milestone Dec 8, 2017
@rchaganti
Copy link
Contributor

I just started NetworkingDsc in my account. I have a new resource that I needed and thought why not start making it as a HQRM. You can check it at https://github.com/rchaganti/NetworkingDsc.

@PlagueHO
Copy link
Member Author

Hi @rchaganti - great stuff! Are you planning on merging your NetworkingDsc in with this repo once we've completed the rename?

@rchaganti
Copy link
Contributor

Yes. Do you have any timelines?

@PlagueHO
Copy link
Member Author

I wanted to complete #135 before converting to NetworkingDsc, but I think this will take at least a few weeks if I do one resource every couple of days (takes a little bit of time for reviews to go through). But there isn't strictly any reason why I need to complete the HQRM work before renaming this module.

I'd love to have this complete before next resource kit release (end of Jan?) - so would that timeline work for you?

@rchaganti
Copy link
Contributor

Yes, that will work. I will start adding tests to my resource. Is there any new resource backlog that you are tracking? I can help write some after holidays.

@PlagueHO PlagueHO added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels May 5, 2018
PlagueHO added a commit that referenced this issue May 8, 2018
BREAKING CHANGE: Rename xNetworking to NetworkingDsc - Fixes #290
@joeyaiello joeyaiello removed the in progress The issue is being actively worked on by someone. label May 8, 2018
@PlagueHO
Copy link
Member Author

PlagueHO commented May 8, 2018

Hi @rchaganti - sorry it took so long, but we've now completed the rename of xNetworking to NetworkingDsc. So if the offer of including your resources is still available then they'd be gratefully accepted!

@rchaganti
Copy link
Contributor

@PlagueHO I had the NetAdapterAdvancedProperty with a slightly different implementation. https://github.com/rchaganti/NetworkingDsc/blob/master/DSCResources/NetworkAdapterProperty/NetworkAdapterProperty.Schema.mof

I am not hard coding the property names in the schema as value map. Mine is more of a generic implementation. Please review my code and let me know if that is OK. I plan to remove the ID property from the schema though and implement multiple properties (netadaptername and propertyname as keys). If you think this is OK, I will modify NetAdapterAdvancedProperty in this module and submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants