-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Module Name to NetworkingDsc #290
Comments
I just started NetworkingDsc in my account. I have a new resource that I needed and thought why not start making it as a HQRM. You can check it at https://github.com/rchaganti/NetworkingDsc. |
Hi @rchaganti - great stuff! Are you planning on merging your NetworkingDsc in with this repo once we've completed the rename? |
Yes. Do you have any timelines? |
I wanted to complete #135 before converting to NetworkingDsc, but I think this will take at least a few weeks if I do one resource every couple of days (takes a little bit of time for reviews to go through). But there isn't strictly any reason why I need to complete the HQRM work before renaming this module. I'd love to have this complete before next resource kit release (end of Jan?) - so would that timeline work for you? |
Yes, that will work. I will start adding tests to my resource. Is there any new resource backlog that you are tracking? I can help write some after holidays. |
BREAKING CHANGE: Rename xNetworking to NetworkingDsc - Fixes #290
Hi @rchaganti - sorry it took so long, but we've now completed the rename of xNetworking to NetworkingDsc. So if the offer of including your resources is still available then they'd be gratefully accepted! |
@PlagueHO I had the NetAdapterAdvancedProperty with a slightly different implementation. https://github.com/rchaganti/NetworkingDsc/blob/master/DSCResources/NetworkAdapterProperty/NetworkAdapterProperty.Schema.mof I am not hard coding the property names in the schema as value map. Mine is more of a generic implementation. Please review my code and let me know if that is OK. I plan to remove the ID property from the schema though and implement multiple properties (netadaptername and propertyname as keys). If you think this is OK, I will modify NetAdapterAdvancedProperty in this module and submit a PR. |
As per recent DSC Resource Naming guidelines changes:
https://github.com/PowerShell/DscResources/blob/master/Naming.md
The text was updated successfully, but these errors were encountered: