Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetworkTeam: Not returning the actual current team members #342

Closed
johlju opened this issue Jul 23, 2018 · 0 comments · Fixed by #373
Closed

NetworkTeam: Not returning the actual current team members #342

johlju opened this issue Jul 23, 2018 · 0 comments · Fixed by #373
Labels
bug The issue is a bug. help wanted The issue is up for grabs for anyone in the community.

Comments

@johlju
Copy link
Member

johlju commented Jul 23, 2018

Details of the scenario you tried and the problem that is occurring:
When Get-TargetResource evaluate an existing network team, the returned value for TeamMembers is the same value as assigned in the configuration.

https://github.com/PowerShell/NetworkingDsc/blob/9916993c1a3440aa9c0eb0dadce99cf0b4e74d38/Modules/NetworkingDsc/DSCResources/MSFT_NetworkTeam/MSFT_NetworkTeam.psm1#L46

But here the current team members are evaluated.

https://github.com/PowerShell/NetworkingDsc/blob/9916993c1a3440aa9c0eb0dadce99cf0b4e74d38/Modules/NetworkingDsc/DSCResources/MSFT_NetworkTeam/MSFT_NetworkTeam.psm1#L59-L67

Shouldn't we return the actual team members in the property TeamMembers when the network team exist (or @() if there are no team members yet) ?

The DSC configuration that is using the resource (as detailed as possible):

        NetworkTeam HostTeam
        {
            Name                   = 'HostTeam'
            TeamingMode            = 'SwitchIndependent'
            LoadBalancingAlgorithm = 'HyperVPort'
            TeamMembers            = 'NIC1', 'NIC2'
            Ensure                 = 'Present'
        }

Version of the Operating System and PowerShell the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev

@PlagueHO PlagueHO added bug The issue is a bug. help wanted The issue is up for grabs for anyone in the community. labels Jul 24, 2018
PlagueHO added a commit that referenced this issue Jan 26, 2019
Change NetWorkteam Get-TargetResource to improve behaviour - Fixes #342
@SteveL-MSFT SteveL-MSFT added this to Help Wanted in powershell/dscresources May 14, 2019
@SteveL-MSFT SteveL-MSFT removed this from Help Wanted in powershell/dscresources Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug. help wanted The issue is up for grabs for anyone in the community.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants