Adding xNetAdapterRDMA

[rchaganti]

Adding xNetAdapterRDMA resource for configuring RDMA on network adapters.

---

This change is 

[PlagueHO]

Thanks for resubmitting this @rchaganti - really appreciate all your work on this! Just one tiny little change if you don't mind? Then it

---

Reviewed 9 of 9 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

DSCResources/MSFT_xNetAdapterRDMA/MSFT_xNetAdapterRDMA.schema.mof, line 4 at r1 (raw file):

class MSFT_xNetAdapterRDMA : OMI_BaseResource
{
    [Key] String Name;

Sorry to be a complete pain, but could you add the Description (from the Readme.md if you like) to the MOF files here? I'm eventually hoping we can implement the code that xSharepoint uses which uses the description from the MOF to generate the documentation.

---

DSCResources/MSFT_xNetAdapterRDMA/MSFT_xNetAdapterRDMA.schema.mof, line 5 at r1 (raw file):

{
    [Key] String Name;
    [Write] Boolean Enabled;

Ditto.

---

Comments from Reviewable

[rchaganti]

Review status: 8 of 9 files reviewed at latest revision, 2 unresolved discussions.

---

DSCResources/MSFT_xNetAdapterRDMA/MSFT_xNetAdapterRDMA.schema.mof, line 4 at r1 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Sorry to be a complete pain, but could you add the Description (from the Readme.md if you like) to the MOF files here? I'm eventually hoping we can implement the code that xSharepoint uses which uses the description from the MOF to generate the documentation.

Complete

---

DSCResources/MSFT_xNetAdapterRDMA/MSFT_xNetAdapterRDMA.schema.mof, line 5 at r1 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Ditto.

Complete

---

Comments from Reviewable

[rchaganti]

Done!

[rchaganti]

@PlagueHO do you know why the build is failing? Especially for xFirewall?

[PlagueHO]

@rchaganti - Ok, I know why the integration tests are failing. A change was made to the DSCResources.Tests a few weeks back which caused this. Basically the tests were changed over to use the Pester $TestDrive as working storage.

The solution is to change the line:

& "$($script:DSCResourceName)_Config" -OutputPath $TestEnvironment.WorkingFolder

in each MSFT_*.Integration.Tests.ps1 file to read:

& "$($script:DSCResourceName)_Config" -OutputPath $TestDrive

Would you mind making this change for us?

The problem with xFirewall is actually caused by a bug in DSCResource.Tests. I'll actually submit a PR to DSCResource.Tests to fix this, but to work around the problem:

Change the filename of the xFirewall schema file MSFT_xFirewall.Schema.mof to be use a lower case .Schema (the capital S is the problem). E.g. rename it to MSFT_xFirewall.schema.mof

Thanks again!

[PlagueHO]

@rchaganti - I've submitted a PR to DSCResources.Tests to fix the .schema issue:
PowerShell/DscResource.Tests#82

[rchaganti]

I updated the integration test file based on your feedback.

[PlagueHO]

@rchaganti - hmm. Something else must be going on here. I'll take a look through this tonight and advise exactly what needs to be fixed. Sorry about all this.

The fix for the .Schema has gone through in DSCResources.Tests so that should be resolved.

[PlagueHO]

Hi @rchaganti - ok. Found the problem. There was another change to DSCResource.Tests that effected this. Maybe the best thing for me to do is submit a new PR with all the fixes to support the new tests in place and get that merged.

You can then merge that with your changes. Saves me having to explain all the fixes here. What do you reckon?

[PlagueHO]

Reviewed 1 of 1 files at r2, 1 of 1 files at r5.
Review status: 8 of 9 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

---

Tests/Integration/MSFT_xNetAdapterRDMA.Integration.Tests.ps1, line 36 at r5 (raw file):

            {
                & "$($script:DSCResourceName)_Config" -OutputPath $TestDrive
                Start-DscConfiguration -Path $TestEnvironment.WorkingFolder `

My bad - you'll also need to change $TestEnvironment.Working folder here to $TestDrive.

---

Comments from Reviewable

[rchaganti]

Review status: 8 of 9 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

---

Tests/Integration/MSFT_xNetAdapterRDMA.Integration.Tests.ps1, line 36 at r5 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

My bad - you'll also need to change $TestEnvironment.Working folder here to $TestDrive.

Done

---

Comments from Reviewable

[rchaganti]

readme conflict again!?

[PlagueHO]

@rchaganti - unfortunately, yes. This is because PR #168 had to go in so that your tests would not fail. PR #168 included a new entry in the Readme.md to identify the change. But the conflict should be easy to resolve I think. Sorry about that.

[PlagueHO]

@rchaganti - I didn't realize there was a new GitHub feature that allowed me to resolve the conflict for you. So it is resolved.

[PlagueHO]

Reviewed 1 of 1 files at r6, 1 of 1 files at r7.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable