Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Examples for xIPAddress - Fixes #239 #242

Merged
merged 3 commits into from
Jul 30, 2017
Merged

Improved Examples for xIPAddress - Fixes #239 #242

merged 3 commits into from
Jul 30, 2017

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Jul 28, 2017

This PR addresses an issue raised in #239 that came from a question in #238.

It tries to clarify how to set IP Addresses with CIDR notation.


This change is Reviewable

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Jul 28, 2017
@PlagueHO PlagueHO self-assigned this Jul 28, 2017
@codecov-io
Copy link

codecov-io commented Jul 28, 2017

Codecov Report

Merging #242 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #242   +/-   ##
===================================
  Coverage    97%    97%           
===================================
  Files        17     17           
  Lines      1321   1321           
===================================
  Hits       1284   1284           
  Misses       37     37

@tysonjhayes
Copy link
Collaborator

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@tysonjhayes tysonjhayes merged commit 2a850cd into dsccommunity:dev Jul 30, 2017
@joeyaiello joeyaiello removed the needs review The pull request needs a code review. label Jul 30, 2017
@PlagueHO PlagueHO deleted the Issue-239 branch February 2, 2018 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants