New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled PSSA rule violations to fail build - Fixes #320 #321

Merged

tysonjhayes merged 1 commit into dsccommunity:dev from PlagueHO:Issue-320

Apr 5, 2018

Member

PlagueHO commented Apr 5, 2018 •

edited by joeyaiello

Loading

Pull Request (PR) description
Enable PSSA rule violations to fail build by opting in to new meta settings in DSCResource.Tests.

This Pull Request (PR) fixes the following issues:
#320

Task list:

Change details added to Unreleased section of CHANGELOG.md?
Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
Examples appropriately updated?
New/changed code adheres to Style Guidelines?
Unit and (optional) Integration tests created/updated where possible?

@tysonjhayes or @johlju - would either of you mind reviewing this one?

This change is


          Enabled PSSA rule violations to fail build

e2e2167

PlagueHO added enhancement in progress needs review and removed enhancement in progress labels

tysonjhayes merged commit 4fa655b into dsccommunity:dev

joeyaiello removed the needs review label

Collaborator

tysonjhayes commented Apr 5, 2018

LGTM.

PlagueHO deleted the Issue-320 branch

April 6, 2018 09:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment