Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Gallery_Api Environment variable to AppVeyor - Fixes #385 #386

Merged
merged 2 commits into from
Apr 1, 2019
Merged

Added Gallery_Api Environment variable to AppVeyor - Fixes #385 #386

merged 2 commits into from
Apr 1, 2019

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Mar 30, 2019

Pull Request (PR) description

This PR fixes the example publish to PS Gallery by adding the missing environment variable to AppVeyor

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - one more for you! Thanks Johann!


This change is Reviewable

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Mar 30, 2019
@codecov-io
Copy link

Codecov Report

Merging #386 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #386   +/-   ##
===================================
  Coverage    95%    95%           
===================================
  Files        27     27           
  Lines      2144   2144           
===================================
  Hits       2053   2053           
  Misses       91     91

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@39Delta
Copy link
Contributor

39Delta commented Apr 1, 2019

LGTM

@39Delta 39Delta closed this Apr 1, 2019
@kwirkykat kwirkykat removed the needs review The pull request needs a code review. label Apr 1, 2019
@39Delta 39Delta reopened this Apr 1, 2019
@39Delta 39Delta merged commit 4661a22 into dsccommunity:dev Apr 1, 2019
@PlagueHO PlagueHO deleted the Issue-385 branch April 1, 2019 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example Publishing to PS Gallery Fails
5 participants