Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OfficeOnlineServerDsc: Update to latest pipeline files #64

Merged
merged 10 commits into from
Nov 5, 2023

Conversation

johlju
Copy link
Member

@johlju johlju commented Nov 5, 2023

Pull Request (PR) description

  • OfficeOnlineServerDsc
    • Updated to latest pipeline files.

This Pull Request (PR) fixes the following issues

None.

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Merging #64 (1b2b604) into master (fb6e5b4) will decrease coverage by 5%.
Report is 101 commits behind head on master.
The diff coverage is 79%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #64    +/-   ##
=====================================
- Coverage      85%   80%    -5%     
=====================================
  Files           5     6     +1     
  Lines         594   759   +165     
=====================================
+ Hits          506   613   +107     
- Misses         88   146    +58     
Files Coverage Δ
...eOnlineServerFarm/MSFT_OfficeOnlineServerFarm.psm1 95% <100%> (ø)
...eServerMachine/MSFT_OfficeOnlineServerMachine.psm1 98% <98%> (ø)
...ck/MSFT_OfficeOnlineServerInstallLanguagePack.psm1 88% <88%> (ø)
...eServerInstall/MSFT_OfficeOnlineServerInstall.psm1 84% <84%> (ø)
...ctUpdate/MSFT_OfficeOnlineServerProductUpdate.psm1 77% <77%> (ø)
...lineServerDsc.Util/OfficeOnlineServerDsc.Util.psm1 59% <59%> (ø)

... and 2 files with indirect coverage changes

@johlju
Copy link
Member Author

johlju commented Nov 5, 2023

For some reason this repository is missing a unit test that was merged together with a new resource. I not sure what commit removed it, but must be a mistake so this PR adds it back to raise coverage.

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 15 of 16 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit 7358992 into dsccommunity:master Nov 5, 2023
8 of 9 checks passed
@johlju johlju deleted the fix/pipeline-files branch November 5, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant