Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlLogin: Add integration test for testing changing passwords for SQL login #1050

Closed
johlju opened this issue Feb 20, 2018 · 0 comments · Fixed by #1652
Closed

SqlLogin: Add integration test for testing changing passwords for SQL login #1050

johlju opened this issue Feb 20, 2018 · 0 comments · Fixed by #1652
Labels
enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Feb 20, 2018

Details of the scenario you tried and the problem that is occurring:
The integration tests does not currently test changing password on a SQL login. This resulted in the bug reported in issue #1048 and issue #1032.

We should add a test for this scenario as well.

The DSC configuration that is using the resource (as detailed as possible):
https://github.com/PowerShell/SqlServerDsc/blob/a8cb7528153eb7d7246a41b97c7a28b831686ac5/Tests/Integration/MSFT_SqlServerLogin.config.ps1#L165-L199

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
Any

What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Feb 20, 2018
@johlju johlju mentioned this issue Feb 20, 2018
Merged
5 tasks
@SteveL-MSFT SteveL-MSFT added this to Help Wanted in powershell/dscresources May 14, 2019
@SteveL-MSFT SteveL-MSFT removed this from Help Wanted in powershell/dscresources Nov 27, 2019
@johlju johlju changed the title SqlServerLogin: Add integration test for testing changing passwords for SQL login SqlLogin: Add integration test for testing changing passwords for SQL login Jul 10, 2020
@SphenicPaul SphenicPaul mentioned this issue Dec 14, 2020
Merged
9 tasks
johlju pushed a commit that referenced this issue Jan 12, 2021
@SphenicPaul
SqlLogin: Added and amended integration tests for logins of 'SqlLogin…
9130c05 
…' type (#1652)

- SqlLogin
  - Added functionality to throw exception if an update to the `LoginMustChangePassword`
    value on an existing SQL Login is attempted. This functionality is not supported
    by referenced, SQL Server Management Object (SMO), libraries and cannot be
    supported directly by this module.
  - Added integration tests to ensure that an added (or updated) `SqlLogin` can
    connect into a SQL instance once added (or updated).
  - Added integration tests to ensure that the default database connected to by
    a `SqlLogin` is the same as specified in the resource's `DefaultDatabase`
    property/parameter.
  - Reversed order in which `PasswordExpirationEnabled` and `PasswordPolicyEnforced`
    are updated within `SqlLogin` resource. `PasswordPolicyEnforced` is now updated
    first.
  - Added integration tests to assert `LoginPasswordExpirationEnabled`,
    `LoginPasswordPolicyEnforced` and `LoginMustChangePassword` properties/parameters
    are applied and updated correctly. Similar integration tests also added to ensure
    the password of the `SqlLogin` is updated if the password within the `SqlCredential`
    value/object is changed (issue #361, issue #1032, and issue #1050).
  - Updated `SqlLogin`, integration tests to make use of amended `Wait-ForIdleLcm`,
    helper function, `-Clear` switch usage to remove intermittent, integration
    test failures (issue #1634).
@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
1 participant
@johlju