SqlRSSetup: EditionUpgrade parameter bug. #1398
Labels
bug
The issue is a bug.
good first issue
The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Details of the scenario you tried and the problem that is occurring
The parameter is a bool. Normally it should support $True to use it and $False to skip it. The way the ressource is built, whatever the value passed, since it's defined, it will act as if the value was set to $True. In documentation, it say the default value is $False but looking at the code it's $NULL. When the parameter isn't specified, it work as expected. I assumed the only tests that were done are with the value at $True and at $NULL.
Verbose logs showing the problem
N/A
Suggested solution to the issue
Add a test on the value to make sure is $True instead of just defined. (In the Set function at least)
The DSC configuration that is used to reproduce the issue (as detailed as possible)
N/A
SQL Server edition and version the target node is running
2017 Standard
SQL Server PowerShell modules present on the target node
N/A
The operating system the target node is running
Windows Server 2016
Version and build of PowerShell the target node is running
5.1.14393.2969
10.0.14393.2969
Version of the DSC module that was used ('dev' if using current dev branch)
13.0.0.0
The text was updated successfully, but these errors were encountered: