Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xSQLServerSetup references Setup ProcessID but doesnt capture it #41

Closed
kilasuit opened this issue Mar 11, 2016 · 3 comments · Fixed by #578
Closed

xSQLServerSetup references Setup ProcessID but doesnt capture it #41

kilasuit opened this issue Mar 11, 2016 · 3 comments · Fixed by #578
Labels
bug The issue is a bug.

Comments

@kilasuit
Copy link

In the possible variables there is a PID Variable being used that is meant to be used to capture the process for the SQL Setup.exe

However the PID variable doesn't get set properly and because of this causes the Set method to close early which then invokes the test method straight away causing it to error out
@kilasuit
Copy link
Author

Oddly on a further run when the SQL media is extracted to the source folder as specified in #40 this runs and does correctly grab the process ID

However I do still think that the dependency on #40 could be made to be more dynamic and allow ISO mounts instead of being hardcoded still.

@anwather
Copy link

Facing the same issue - the process is launched however the Test fails soon after.

@kwirkykat kwirkykat added bug The issue is a bug. help wanted The issue is up for grabs for anyone in the community. labels Aug 2, 2016
@johlju
Copy link
Member

johlju commented Nov 4, 2016 •
edited
Loading

This will be resolved when PR #123 is merged. Or, it will be obsolete. :)

@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels May 21, 2017
@johlju johlju self-assigned this May 21, 2017
johlju added a commit to johlju/SqlServerDsc that referenced this issue May 21, 2017
@johlju
Changes to xSQLServerSetup
553c264 
BREAKING CHANGE: Replaced StartWin32Process helper function with the cmdlet Start-Process (issue dsccommunity#41, dsccommunity#93 and dsccommunity#126).
@johlju johlju mentioned this issue May 25, 2017
Merged
5 tasks
johlju added a commit to johlju/SqlServerDsc that referenced this issue May 27, 2017
@johlju
Changes to xSQLServerSetup
9880433 
BREAKING CHANGE: Replaced StartWin32Process helper function with the cmdlet Start-Process (issue dsccommunity#41, dsccommunity#93 and dsccommunity#126).
johlju added a commit to johlju/SqlServerDsc that referenced this issue May 30, 2017
@johlju
Changes to xSQLServerSetup
fb2313f 
BREAKING CHANGE: Replaced StartWin32Process helper function with the cmdlet Start-Process (issue dsccommunity#41, dsccommunity#93 and dsccommunity#126).
johlju added a commit to johlju/SqlServerDsc that referenced this issue Jun 3, 2017
@johlju
Changes to xSQLServerSetup
6128584 
BREAKING CHANGE: Replaced StartWin32Process helper function with the cmdlet Start-Process (issue dsccommunity#41, dsccommunity#93 and dsccommunity#126).
johlju added a commit to johlju/SqlServerDsc that referenced this issue Jun 4, 2017
@johlju
Changes to xSQLServerSetup
91bc74b 
BREAKING CHANGE: Replaced StartWin32Process helper function with the cmdlet Start-Process (issue dsccommunity#41, dsccommunity#93 and dsccommunity#126).
johlju added a commit to johlju/SqlServerDsc that referenced this issue Jun 5, 2017
@johlju
Changes to xSQLServerSetup
b48a14d 
BREAKING CHANGE: Replaced StartWin32Process helper function with the cmdlet Start-Process (issue dsccommunity#41, dsccommunity#93 and dsccommunity#126).
johlju added a commit that referenced this issue Jun 6, 2017
@johlju
BREAKING CHANGE: xSQLServer: Removed deprecated resources and WMF 4.0…
71b5cc4 
… support, xSQLServerSetup supports PsDscRunAsCredential (#578)

- Changes to xSQLServer
  - BREAKING CHANGE: xSQLServer does no longer try to support WMF 4.0 (PowerShell 4.0) (issue #574). Minimum supported version of WMF is now 5.0 (PowerShell 5.0).
  - BREAKING CHANGE: Removed deprecated resource xSQLAOGroupJoin (issue #457).
  - BREAKING CHANGE: Removed deprecated resource xSQLAOGroupEnsure (issue #456).
  - BREAKING CHANGE: Removed deprecated resource xSQLServerFailoverClusterSetup (issue #336).
- Changes to xSQLServerHelper
  - Removed helper function Grant-ServerPerms because the deprecated resource that was using it was removed.
  - Removed helper function Grant-CNOPerms because the deprecated resource that was using it was removed.
  - Removed helper function New-ListenerADObject because the deprecated resource that was using it was removed.
- Changes to xSQLServerSetup
  - BREAKING CHANGE: Replaced StartWin32Process helper function with the cmdlet Start-Process (issue #41, #93 and #126).
  - BREAKING CHANGE: The parameter SetupCredential has been removed since it is no longer needed. This is because the resource now support the built-in PsDscRunAsCredential.
  - BREAKING CHANGE: Now the resource supports using built-in PsDscRunAsCredential. If PsDscRunAsCredential is set, that username will be used as the first system administrator.
  - BREAKING CHANGE: If the parameter PsDscRunAsCredential are not assigned any credentials then the resource will start the setup process as the SYSTEM account. When installing as the SYSTEM account, then parameter SQLSysAdminAccounts and ASSysAdminAccounts must be specified when installing feature Database Engine and Analysis Services respectively.
  - When setup exits with the exit code 3010 a warning message is written to console telling that setup finished successfully, but a reboot is required (partly fixes issue #565).
  - When setup exits with an exit code other than 0 or 3010 a warning message is written to console telling that setup finished with an error (partly fixes issue #580).
  - Added a new parameter SetupProcessTimeout which defaults to 7200 seconds (2 hours). If the setup process has not finished before the timeout value in SetupProcessTimeout an error will be thrown (issue #566).
  - Updated all examples to match the removal of SetupCredential.
  - Updated (removed) severe known issues in README.md for resource xSQLServerSetup.
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jun 6, 2017
@johlju johlju removed their assignment Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug The issue is a bug.
Projects
None yet
Milestone
No milestone
4 participants
@kilasuit @kwirkykat @johlju @anwather