Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: SqlDatabasePermission: Remove database user creation, and add assigning permission to roles #848

Closed
bozho opened this issue Sep 25, 2017 · 3 comments · Fixed by #1556
Closed

BREAKING CHANGE: SqlDatabasePermission: Remove database user creation, and add assigning permission to roles #848

bozho opened this issue Sep 25, 2017 · 3 comments · Fixed by #1556
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.

Comments

@bozho
Copy link
Contributor

bozho commented Sep 25, 2017

xSQLServerDatabasePermission can currently only assign DB permissions to DB users. It will also create a DB user if it doesn't already exist.

In order to simplify the resource and enable further enhancements (e.g. assigning permissions to roles), I suggest that DB user creation/removal is only handled in xSQLServerDatabaseUser (issue #846) and that xSQLServerDatabasePermission is altered to only handle permissions on users and roles.
@bozho bozho mentioned this issue Sep 25, 2017
Open
@johlju
Copy link
Member

johlju commented Sep 26, 2017

I agree to this. This will be a breaking change. This change should be merged once issue #846 is merged.

@johlju johlju changed the title xSQLServerDatabasePermission changes BREAKING CHANGE: xSQLServerDatabasePermission: Remove database user creation from this resource. Sep 26, 2017
@johlju johlju changed the title BREAKING CHANGE: xSQLServerDatabasePermission: Remove database user creation from this resource. BREAKING CHANGE: xSQLServerDatabasePermission: Remove database user creation from this resource Sep 26, 2017
@johlju johlju changed the title BREAKING CHANGE: xSQLServerDatabasePermission: Remove database user creation from this resource BREAKING CHANGE: xSQLServerDatabasePermission: Remove database user creation from this resource and add assigning permission to roles Sep 26, 2017
@johlju johlju changed the title BREAKING CHANGE: xSQLServerDatabasePermission: Remove database user creation from this resource and add assigning permission to roles BREAKING CHANGE: xSQLServerDatabasePermission: Remove database user creation, and add assigning permission to roles Sep 26, 2017
@johlju
Copy link
Member

johlju commented Sep 26, 2017

@bozho Does the schema.mof need to change for this? Can you propose a schema.mof?

@johlju johlju added breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Sep 26, 2017
@johlju johlju changed the title BREAKING CHANGE: xSQLServerDatabasePermission: Remove database user creation, and add assigning permission to roles BREAKING CHANGE: SqlDatabasePermission: Remove database user creation, and add assigning permission to roles Dec 23, 2017
@johlju johlju mentioned this issue Jun 6, 2018
Closed
@SteveL-MSFT SteveL-MSFT added this to Help Wanted in powershell/dscresources May 14, 2019
@SteveL-MSFT SteveL-MSFT removed this from Help Wanted in powershell/dscresources Nov 27, 2019
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels May 23, 2020
@johlju johlju mentioned this issue May 23, 2020
Merged
9 tasks
johlju added a commit that referenced this issue May 25, 2020
@johlju
BREAKING CHANGE: SqlDatabasePermission: Remove create user (#1556)
e711c4a 
- SqlDatabasePermission
  - BREAKING CHANGE: The resource no longer create the database user if
    it does not exist. Use the resource _SqlDatabaseUser_ to enforce that
    the database user exist in the database prior to setting permissions
    using this resource (issue #848).
  - BREAKING CHANGE: The resource no longer checks if a login exist so that
    it is possible to set permissions for database users that does not
    have a login, e.g. the database user 'guest' (issue #1134).
  - Updated examples.
  - Added integration tests (issue #741).
  - Get-TargetResource will no longer throw an exception if the database
    does not exist.
@johlju johlju removed the in progress The issue is being actively worked on by someone. label May 25, 2020
@johlju
Copy link
Member

johlju commented May 25, 2020

This will be fixed in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BREAKING CHANGE: SqlDatabasePermission: Remove create user johlju/SqlServerDsc
2 participants
@bozho @johlju