Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerDsc: Updated ISSUE_TEMPLATE to hopefully be more intuitive #1061

Merged
merged 2 commits into from Mar 12, 2018

Conversation

johlju
Copy link
Member

@johlju johlju commented Mar 10, 2018

Pull Request (PR) description

This Pull Request (PR) fixes the following issues:
Fixes #1036

Task list:

  • Change details added to Unreleased section of CHANGELOG.md?
  • Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Mar 10, 2018
@codecov-io
Copy link

codecov-io commented Mar 10, 2018

Codecov Report

Merging #1061 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##            dev   #1061   +/-   ##
====================================
  Coverage    97%     97%           
====================================
  Files        32      32           
  Lines      3930    3930           
====================================
  Hits       3844    3844           
  Misses       86      86

@johlju
Copy link
Member Author

johlju commented Mar 12, 2018

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


.github/ISSUE_TEMPLATE.md, line 36 at r1 (raw file):

$registryPath = 'HKLM:\SOFTWARE\Microsoft\Microsoft SQL Server'
$sqlInstance = (Get-ItemProperty -Path $registryPath).InstalledInstances
$sqlInstance | ForEach-Object -Process {
 
$instanceId = (Get-ItemProperty "$registryPath\Instance Names\SQL").$_
(Get-ItemProperty "$registryPath$instanceId\Setup") | fl Edition,Version, Language
}

Suggesting this to handle when a instance does not exist on the target node.

    $registryPath = 'HKLM:\SOFTWARE\Microsoft\Microsoft SQL Server'
    $sqlInstance = (Get-ItemProperty -Path $registryPath -ErrorAction 'SilentlyContinue').InstalledInstances
    $sqlInstance | ForEach-Object -Process {
        $instanceId = (Get-ItemProperty "$registryPath\Instance Names\SQL" -ErrorAction 'SilentlyContinue').$_
        (Get-ItemProperty "$registryPath\$instanceId\Setup" -ErrorAction 'SilentlyContinue') | fl Edition,Version, Language
    }

.github/ISSUE_TEMPLATE.md, line 51 at r1 (raw file):

or 'dev' if you're

or write...


Comments from Reviewable

@johlju
Copy link
Member Author

johlju commented Mar 12, 2018

Review status: 1 of 2 files reviewed at latest revision, 2 unresolved discussions.


.github/ISSUE_TEMPLATE.md, line 36 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

$registryPath = 'HKLM:\SOFTWARE\Microsoft\Microsoft SQL Server'
$sqlInstance = (Get-ItemProperty -Path $registryPath).InstalledInstances
$sqlInstance | ForEach-Object -Process {
 
$instanceId = (Get-ItemProperty "$registryPath\Instance Names\SQL").$_
(Get-ItemProperty "$registryPath$instanceId\Setup") | fl Edition,Version, Language
}

Suggesting this to handle when a instance does not exist on the target node.

    $registryPath = 'HKLM:\SOFTWARE\Microsoft\Microsoft SQL Server'
    $sqlInstance = (Get-ItemProperty -Path $registryPath -ErrorAction 'SilentlyContinue').InstalledInstances
    $sqlInstance | ForEach-Object -Process {
        $instanceId = (Get-ItemProperty "$registryPath\Instance Names\SQL" -ErrorAction 'SilentlyContinue').$_
        (Get-ItemProperty "$registryPath\$instanceId\Setup" -ErrorAction 'SilentlyContinue') | fl Edition,Version, Language
    }

Done.


.github/ISSUE_TEMPLATE.md, line 51 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

or 'dev' if you're

or write...

Done.


Comments from Reviewable

@johlju
Copy link
Member Author

johlju commented Mar 12, 2018

:LGTM:


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

- Updated the ISSUE_TEMPLATE to hopefully be more intuitive and easier
  to use.
- Added information to ISSUE_TEMPLATE that issues must be reproducible
  in SqlServerDsc resource module (if running the older xSQLServer
  resource module (issue dsccommunity#1036).
@johlju
Copy link
Member Author

johlju commented Mar 12, 2018

:LGTM:


Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@johlju johlju merged commit 1d33111 into dsccommunity:dev Mar 12, 2018
@johlju johlju removed the needs review The pull request needs a code review. label Mar 17, 2018
@johlju johlju deleted the fix-issue-1036 branch March 30, 2018 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ISSUE_TEMPLATE: Add that bugs must be reproducible with SqlServerDsc
2 participants