BREAKING CHANGE: xSQLServerSetup: Removed SourceFolder & default value

[johlju]

• Changes to xSQLServerSetup
  • BREAKING CHANGE: Removed parameter SourceFolder.
  • BREAKING CHANGE: Removed default value "$PSScriptRoot...." from parameter SourcePath.
  • Old code, that no longer filled any function, has been replaced.
    • Function ResolvePath has been replaced with [Environment]::ExpandEnvironmentVariables($SourcePath) so that environment variables still can be used in Source Path.
    • Function NetUse has been replaced with New-SmbMapping and Remove-SmbMapping.
  • Renamed function GetSQLVersion to Get-SqlMajorVersion.
• Changes to xSQLServerHelper
  • Resolved all the white space in xSQLServerHelper.psm1

This Pull Request (PR) fixes the following issues:
Fixes #40
Fixes #196

• Change details added to Unreleased section of CHANGELOG.md?
• Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
• Examples appropriately updated?
• New/changed code adheres to Style Guidelines?
• Unit and (optional) Integration tests created/updated where possible?

---

This change is 

[johlju]

Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, 5 unresolved discussions.

---

README.md, line 749 at r1 (raw file):

If the path set in parameter SourcePath contains

If the path, that is assigned to parameter SourcePath, contains

then the that leaf folder

then that leaf folder

If the path set in parameter SourcePath does not have

If the path, that is assigned to parameter SourcePath, does not have

---

DSCResources/MSFT_xSQLServerSetup/MSFT_xSQLServerSetup.psm1, line 20 at r1 (raw file):

        For any subsequent calls to the resource, the parameter `SourceCredential` is used to evaluate what major version the file 'setup.exe'
        has in the path set, again, by the parameter `SourcePath`.
        If the path set in parameter `SourcePath` contains a leaf folder, for example '\\server\share\folder', then the that leaf

Same as the comment above

---

DSCResources/MSFT_xSQLServerSetup/MSFT_xSQLServerSetup.psm1, line 332 at r1 (raw file):

        has in the path set, again, by the parameter `SourcePath`.
        If the path set in parameter `SourcePath` contains a leaf folder, for example '\\server\share\folder', then the that leaf
        folder will be used as the name of the temporary folder. If the path set in parameter `SourcePath` does not have a leaf folder,

Same as the comment above

---

DSCResources/MSFT_xSQLServerSetup/MSFT_xSQLServerSetup.psm1, line 902 at r1 (raw file):

        has in the path set, again, by the parameter `SourcePath`.
        If the path set in parameter `SourcePath` contains a leaf folder, for example '\\server\share\folder', then the that leaf
        folder will be used as the name of the temporary folder. If the path set in parameter `SourcePath` does not have a leaf folder,

Same as the comment above

---

DSCResources/MSFT_xSQLServerSetup/MSFT_xSQLServerSetup.schema.mof, line 6 at r1 (raw file):

    [Write, Description("The path to the root of the source files for installation. I.e and UNC path to a shared resource. Environment variables can be used in the path.")] String SourcePath;
    [Required, EmbeddedInstance("MSFT_Credential"), Description("Credential to be used to perform the installation.")] String SetupCredential;
    [Write, EmbeddedInstance("MSFT_Credential"), Description("Credentials used to access the path set in the parameter 'SourcePath'. Using this parameter will trigger a copy of the installation media to a temp folder on the target node. Setup will then be started from the temp folder on the target node. For any subsequent calls to the resource, the parameter 'SourceCredential' is used to evaluate what major version the file 'setup.exe' has in the path set, again, by the parameter 'SourcePath'.")] String SourceCredential;

Make this a shorter description than the one in README.md and comment-based help, to align with PSDscResources

---

Comments from Reviewable

[johlju]

---

Reviewed 3 of 3 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable