Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and and tests for issues #23, merging code from PR #19 #21

Merged
merged 9 commits into from
Feb 23, 2016
Merged

Fixes and and tests for issues #23, merging code from PR #19 #21

merged 9 commits into from
Feb 23, 2016

Conversation

TravisEz13
Copy link
Contributor

Will follow up with fixes later, verifying the tests find the problem first

asos-richardgibson and others added 2 commits February 9, 2016 16:55
…g expanded. The following code used to be an incorrect mixture of usages of $BlockSize and $BlockSize.BlockSize
@msftclas
Copy link

Hi @TravisEz13, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Travis Plunk). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@TravisEz13
Copy link
Contributor Author

Merged PR #19

@TravisEz13 TravisEz13 changed the title Added tests for issue reported in PR #19 Fixes and and tests for issues #23, merging code from PR #19 Feb 20, 2016
@TravisEz13
Copy link
Contributor Author

Fixes #23


Mock Get-Volume -mockwith {
return $global:mockedVolume
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to have unified format (all in one line or all separated into three lines). Same for above places.

@zhenl-microsoft
Copy link

Reviewed. Looks good to me.

TravisEz13 added a commit that referenced this pull request Feb 23, 2016
Fixes and and tests for issues #23, merging code from PR #19
@TravisEz13 TravisEz13 merged commit a0c736d into dsccommunity:dev Feb 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants