Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove space between 'Dev Drive' tag in psd1 file so deployment passes #281

Merged
merged 2 commits into from Oct 28, 2023

Conversation

bbonaby
Copy link
Contributor

@bbonaby bbonaby commented Oct 28, 2023

Pull Request (PR) description

This PR removes the whitespace between the 'Dev Drive' tag in the psd1 file. This should allow the deployment to pass. Thats my bad for doing a find and replace in the previous PR.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Merging #281 (bdf1049) into main (ef70e54) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #281   +/-   ##
===================================
  Coverage    95%    95%           
===================================
  Files         7      7           
  Lines      1025   1025           
===================================
  Hits        977    977           
  Misses       48     48           

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @bbonaby)

@johlju johlju merged commit 6473a60 into dsccommunity:main Oct 28, 2023
11 checks passed
@johlju
Copy link
Member

johlju commented Oct 28, 2023

Thanks for fixing this! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The deploy fails because there is a space in a tag in the module manifest
2 participants