Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger BREAKING CHANGE major release - Fixes #282 #283

Merged
merged 2 commits into from Oct 30, 2023
Merged

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Oct 29, 2023

@johlju - this is a BREAKING CHANGE commit. I'm going to squash merge this into a new commit anyway (with BREAKING CHANGE) to trigger the major version bump.

Pull Request (PR) description

Administrative PR to force major version bump.,

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

@johlju - would you mind reviewing when you have time?


This change is Reviewable

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @PlagueHO)

@johlju
Copy link
Member

johlju commented Oct 29, 2023

Not sure why the review message says it’s waiting for you @PlagueHO. All files looks good to me and can’t see I missed any. Very strange.

Good to squash merge.

@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

Merging #283 (a9c3a7d) into main (6473a60) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #283   +/-   ##
===================================
  Coverage    95%    95%           
===================================
  Files         7      7           
  Lines      1025   1025           
===================================
  Hits        977    977           
  Misses       48     48           

@johlju
Copy link
Member

johlju commented Oct 29, 2023

Btw the commit message “bump major version” suffice as commit message too. It looks for these keywords:

major-version-bump-message: '\s?(breaking|major|breaking\schange)'

@PlagueHO PlagueHO merged commit a87725b into main Oct 30, 2023
11 checks passed
@PlagueHO PlagueHO deleted the Issue-282 branch October 30, 2023 19:27
@PlagueHO
Copy link
Member Author

Thanks @johlju - hopefully will work now. I'll get you to remove the old preview package once the new 6 preview is published.

@johlju
Copy link
Member

johlju commented Oct 31, 2023

Since v6 was released I have unlisted the 5.2.0-preview1 version. It won’t show up in search results any longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants