New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger BREAKING CHANGE major release - Fixes #282 #283
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @PlagueHO)
Not sure why the review message says it’s waiting for you @PlagueHO. All files looks good to me and can’t see I missed any. Very strange. Good to squash merge. |
Codecov Report
@@ Coverage Diff @@
## main #283 +/- ##
===================================
Coverage 95% 95%
===================================
Files 7 7
Lines 1025 1025
===================================
Hits 977 977
Misses 48 48 |
Btw the commit message “bump major version” suffice as commit message too. It looks for these keywords: Line 3 in 6473a60
|
Thanks @johlju - hopefully will work now. I'll get you to remove the old preview package once the new 6 preview is published. |
Since v6 was released I have unlisted the 5.2.0-preview1 version. It won’t show up in search results any longer. |
@johlju - this is a BREAKING CHANGE commit. I'm going to squash merge this into a new commit anyway (with BREAKING CHANGE) to trigger the major version bump.
Pull Request (PR) description
Administrative PR to force major version bump.,
This Pull Request (PR) fixes the following issues
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
and comment-based help.
@johlju - would you mind reviewing when you have time?
This change is