-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI display names to tasks - Fixes #63 #65
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
azure-pipelines.yml, line 184 at r1 (raw file):
publishPrerelease
Non-blocking. I changed this to publishRelease
since it also releases full releases (and changed the display name accordingly)
I let you change the branch protection rules before you merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @PlagueHO)
azure-pipelines.yml, line 185 at r2 (raw file):
'Publish Prerelease'
You should change this too :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johlju - I made some other mistakes - can you review again for me? I'll also correct branch protection.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @johlju)
azure-pipelines.yml, line 185 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
'Publish Prerelease'
You should change this too :)
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved
Pull Request (PR) description
Add CI display names to tasks.
This Pull Request (PR) fixes the following issues
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
and comment-based help.
@johlju - would you mind reviewing for me?
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)