Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DSCResource.Common, Pin Pester and Support ModuleBuilder 1.7.0 #81

Merged
merged 2 commits into from
Jun 14, 2020

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Jun 14, 2020

Pull Request (PR) description

Updates module to use DSCResource.Common.
This PR pins Pester to 4.10.1 and updates Build.yml to support ModuleBuilder 1.7.0.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

@johlju - would you mind reviewing this one when you have time?


This change is Reviewable

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 10 of 10 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju added the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label Jun 14, 2020
@PlagueHO PlagueHO merged commit d3a541c into dsccommunity:master Jun 14, 2020
@PlagueHO PlagueHO deleted the Issue-78 branch June 14, 2020 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge The pull request was approved by the community and is ready to be merged by a maintainer.
Projects
None yet
2 participants