Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xWebAdministration: Minor typo updates #388

Merged
merged 1 commit into from
Jul 30, 2018
Merged

Conversation

johlju
Copy link
Member

@johlju johlju commented Jul 26, 2018

  • Update section header for WebApplicationHandler in README.
  • Fix tests for helper function Get-LocalizedData in Helper.Tests.ps1
    that referenced the wrong path.

This change is Reviewable

- Update section header for WebApplicationHandler in README.
- Fix tests for helper function `Get-LocalizedData` in Helper.Tests.ps1
  that referenced the wrong path.
@johlju johlju requested a review from regedit32 July 26, 2018 12:29
@johlju johlju added the needs review The pull request needs a code review. label Jul 26, 2018
@codecov-io
Copy link

codecov-io commented Jul 26, 2018

Codecov Report

Merging #388 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #388   +/-   ##
=======================================
  Coverage   90.43%   90.43%           
=======================================
  Files          17       17           
  Lines        2467     2467           
=======================================
  Hits         2231     2231           
  Misses        236      236

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6501119...b9284b0. Read the comment docs.

Copy link
Member

@regedit32 regedit32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju
Copy link
Member Author

johlju commented Jul 30, 2018

@regedit32 when you approve changes, you can merge them (regardless if they are from a maintainer or contributor). 🙂 I merging this now.

@johlju johlju merged commit 0fd8568 into dsccommunity:dev Jul 30, 2018
@johlju johlju removed the needs review The pull request needs a code review. label Jul 30, 2018
@johlju johlju deleted the fix-readme branch July 30, 2018 11:55
chasewilson pushed a commit to chasewilson/xWebAdministration that referenced this pull request Jul 30, 2018
- Update section header for WebApplicationHandler in README.
- Fix tests for helper function `Get-LocalizedData` in Helper.Tests.ps1
  that referenced the wrong path.
gstorme pushed a commit to gstorme/xWebAdministration that referenced this pull request Feb 14, 2020
- Update section header for WebApplicationHandler in README.
- Fix tests for helper function `Get-LocalizedData` in Helper.Tests.ps1
  that referenced the wrong path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants