Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xBitlocker: Updated to a new CI/CD pipeline #55

Merged
merged 9 commits into from Aug 28, 2020
Merged

xBitlocker: Updated to a new CI/CD pipeline #55

merged 9 commits into from Aug 28, 2020

Conversation

johlju
Copy link
Member

@johlju johlju commented Aug 28, 2020

Pull Request (PR) description

  • Updated to a new CI/CD pipeline

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Aug 28, 2020
@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

❗ No coverage uploaded for pull request base (dev@24a835b). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##             dev    #55   +/-   ##
====================================
  Coverage       ?   100%           
====================================
  Files          ?      4           
  Lines          ?    247           
  Branches       ?      0           
====================================
  Hits           ?    247           
  Misses         ?      0           
  Partials       ?      0           
Flag Coverage Δ
#unit 100% <100%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/MSFT_xBLAutoBitlocker/MSFT_xBLAutoBitlocker.psm1 100% <100%> (ø)
...Resources/MSFT_xBLBitlocker/MSFT_xBLBitlocker.psm1 100% <100%> (ø)
source/DSCResources/MSFT_xBLTpm/MSFT_xBLTpm.psm1 100% <100%> (ø)
...e/Modules/xBitlocker.Common/xBitlocker.Common.psm1 100% <100%> (ø)

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 52 of 52 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit ab86aa5 into dev Aug 28, 2020
@johlju johlju deleted the add-new-ci branch August 28, 2020 13:20
@johlju johlju removed the needs review The pull request needs a code review. label Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xBitlocker: Converting to new CI pipeline
1 participant