BREAKING CHANGE: Update to new CI

[PlagueHO]

Pull Request (PR) description

This PR updates to the new CI process.

This Pull Request (PR) fixes the following issues

• Fixes Update module to new CI and release process #650

Task list

• Added an entry under the Unreleased section of the change log in
  CHANGELOG.md. Entry should say what was changed, and how that affects
  users (if applicable).
• Resource documentation added/updated in README.md.
• Resource parameter descriptions added/updated in README.md, schema.mof
  and comment-based help.
• Comment-based help added/updated.
• Localization strings added/updated in all localization files as
  appropriate.
• Examples appropriately added/updated.
• Unit tests added/updated. See
  DSC Resource Testing Guidelines.
• Integration tests added/updated (where possible). See
  DSC Resource Testing Guidelines.
• New/changed code adheres to
  DSC Resource Style Guidelines and Best Practices

---

This change is 

[PlagueHO]

@mhendric - once this PR is merged, the repo will be in a temporary state that will not be releasable until I add the AzDO pipeline. I'll be removing the AppVeyor, CLA and other processes at the same time. So please don't merge anything until this PR is through.

[johlju]

Reviewed 281 of 281 files at r1.
Reviewable status: all files reviewed, 9 unresolved discussions (waiting on @PlagueHO)

---

azure-pipelines.yml, line 97 at r1 (raw file):

pathToSources: '$(Build.SourcesDirectory)/output/$(DscBuildVariable.RepositoryName)

Missing the powershell task that sets DscBuildVariable (see the "Steps")

---

.github/CONTRIBUTING.md, line 1 at r1 (raw file):

If you'd like to contribute to this project, please review the [Contribution Guidelines](https://github.com/PowerShell/DscResources/blob/master/CONTRIBUTING.md).

Wrong URL here.

---

.github/PULL_REQUEST_TEMPLATE.md, line 51 at r1 (raw file):

testing-guideline

URL: testing-guidelines (should end with 's')

---

.github/PULL_REQUEST_TEMPLATE.md, line 52 at r1 (raw file):

testing-guideline

URL: testing-guidelines (should end with 's')

---

source/xPSDesiredStateConfiguration.psd1, line 46 at r1 (raw file):

Quoted 6 lines of code…

    DscResourcesToExport  = @(
        'xArchive', 'xDSCWebService', 'xEnvironment','xGroup','xMsiPackage',
        'xPackage','xPSSessionConfiguration','xRegistry','xRemoteFile',
        'xScript','xService','xUser','xWindowsFeature','xWindowsOptionalFeature',
        'xWindowsPackageCab','xWindowsProcess'
    )

Information: I will add this to the "Steps" too!

---

source/DSCResources/DSC_xPSSessionConfiguration/DSC_xPSSessionConfiguration.schema.mof, line 1 at r1 (raw file):

xPSEndpoint

Should this say xPsSessionConfiguration? 🤔

---

source/en-US/about_xPSDesiredStateConfiguration.help.txt, line 5 at r1 (raw file):

configuring WS-Man.

Sounds wrong. 😉 Same for the long description below.

---

tests/Integration/DSC_xDSCWebService.Integration.tests.ps1, line 24 at r1 (raw file):

-ErrorAction:Stop

Should be ErrorAction 'Stop'? Did not know it was possible to write it using colon 🤔

---

tests/Unit/DSC_xRemoteFile.Tests.ps1, line 482 at r1 (raw file):

$False

$false (lower-case). Throughout.

---

tests/Unit/DSC_xRemoteFile.Tests.ps1, line 500 at r1 (raw file):

$True

$true (lower-case). Throughout.

[PlagueHO]

Reviewable status: 275 of 281 files reviewed, 9 unresolved discussions (waiting on @johlju)

---

azure-pipelines.yml, line 97 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

pathToSources: '$(Build.SourcesDirectory)/output/$(DscBuildVariable.RepositoryName)

Missing the powershell task that sets DscBuildVariable (see the "Steps")

Done.

---

.github/CONTRIBUTING.md, line 1 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Wrong URL here.

Done.

---

.github/PULL_REQUEST_TEMPLATE.md, line 51 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

testing-guideline

URL: testing-guidelines (should end with 's')

Done.

---

.github/PULL_REQUEST_TEMPLATE.md, line 52 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

testing-guideline

URL: testing-guidelines (should end with 's')

Done.

---

source/DSCResources/DSC_xPSSessionConfiguration/DSC_xPSSessionConfiguration.schema.mof, line 1 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

xPSEndpoint

Should this say xPsSessionConfiguration? 🤔

This is correct, the FriendlyName is supposed to be xPSEndpoint. At some point it might be worth renaming the resource to xPSSessionConfiguration but probably a future change. I did mislabel it in the manifest though so I've corrected that.

---

source/en-US/about_xPSDesiredStateConfiguration.help.txt, line 5 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

configuring WS-Man.

Sounds wrong. 😉 Same for the long description below.

Done.

---

tests/Integration/DSC_xDSCWebService.Integration.tests.ps1, line 24 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

-ErrorAction:Stop

Should be ErrorAction 'Stop'? Did not know it was possible to write it using colon 🤔

Done.

---

tests/Unit/DSC_xRemoteFile.Tests.ps1, line 482 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

$False

$false (lower-case). Throughout.

Done.

---

tests/Unit/DSC_xRemoteFile.Tests.ps1, line 500 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

$True

$true (lower-case). Throughout.

Done.

[johlju]

Reviewed 16 of 16 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

---

tests/Integration/DSC_xDSCWebService.Integration.tests.ps1, line 32 at r2 (raw file):

if ($env:CI -eq $false)

Non-blocking: There are no property in Azure Pipelines called CI (I noticed that in SqlServerDsc as I need to add it to azure-pipelines.yml as a variable). This will always run, since the tests are passing this is a non-issue. But might be worth adding an issue about cleaning this code up? 🤔