Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added codecov support #19

Merged
merged 3 commits into from
Apr 21, 2018
Merged

Added codecov support #19

merged 3 commits into from
Apr 21, 2018

Conversation

TraGicCode
Copy link
Contributor

@TraGicCode TraGicCode commented Apr 17, 2018

This enabled code coverage.

Fixes #18

This change is Reviewable

@codecov-io
Copy link

codecov-io commented Apr 17, 2018

Codecov Report

❗ No coverage uploaded for pull request base (dev@8be95b9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##             dev    #19   +/-   ##
====================================
  Coverage       ?   100%           
====================================
  Files          ?      1           
  Lines          ?     13           
  Branches       ?      0           
====================================
  Hits           ?     13           
  Misses         ?      0           
  Partials       ?      0

@TraGicCode
Copy link
Contributor Author

@johlju What needs to be done to fix the pip install error at the bottom of appveyor?

@johlju
Copy link
Member

johlju commented Apr 20, 2018

Hmm... That seems yet as a new problem, the last error you get we started seeing a while back, see issue PowerShell/DscResource.Tests#203.
It doesn't affect uploading to Codecov (yet), see the file codeCovUpload.log here https://ci.appveyor.com/project/PowerShell/xpowershellexecutionpolicy/build/1.0.66.0/artifacts, it uploads successfully.

Since the problem are escalating we should move to the alternate method mentioned in one of the last comments in the above issue in the DscResource.Tests repo.

@johlju
Copy link
Member

johlju commented Apr 20, 2018

@TraGicCode Please rebase this PR and resolve the merge conflicts. Please use git rebase (and not git pull or git merge). 😃

@johlju johlju changed the title Added codecov support. Added codecov support Apr 20, 2018
@johlju
Copy link
Member

johlju commented Apr 20, 2018

@TraGicCode Remember to add the Codecov badges, looked like they warn't part of the PR? 😃

@TraGicCode
Copy link
Contributor Author

Hey @johlju,

I rebased to fix the merge conflict along with adding the codecov badges to the readme. In regards to the python issue i'm not following what alternate method we should use for this.


Comments from Reviewable

@johlju
Copy link
Member

johlju commented Apr 21, 2018

@TraGicCode Ah, sorry, it was just thinking loud that we (as in the community), in the DscResource.Tests repo, should move the test framework to use an alternate method to uploading the Codecov file. You don't have to do anything in this PR. :) We ignore the errors for now.

I will review this one in a bit. 😃

@johlju
Copy link
Member

johlju commented Apr 21, 2018

Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


appveyor.yml, line 1 at r2 (raw file):

################################################################################

Please remove this comment block (line 1-9)


appveyor.yml, line 15 at r2 (raw file):

1.0.{build}

Please change this to 1.1.{build}.0 which is the version in the file in the dev branch.
Please remove the 'TODO:' comment.


appveyor.yml, line 34 at r2 (raw file):

test_script:
    - ps: |
        # TODO:

Please remove the TODO: comment block (line 34-36)


README.md, line 21 at r2 (raw file):

branch/master

We should set this to 'branch/dev' (at two locations in this line)


Comments from Reviewable

@TraGicCode
Copy link
Contributor Author

Review status: 1 of 3 files reviewed at latest revision, 4 unresolved discussions.


appveyor.yml, line 1 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Please remove this comment block (line 1-9)

Done.


appveyor.yml, line 15 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…
1.0.{build}

Please change this to 1.1.{build}.0 which is the version in the file in the dev branch.
Please remove the 'TODO:' comment.

Done.


appveyor.yml, line 34 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Please remove the TODO: comment block (line 34-36)

Done.


README.md, line 21 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…
branch/master

We should set this to 'branch/dev' (at two locations in this line)

Done.


Comments from Reviewable

@johlju
Copy link
Member

johlju commented Apr 21, 2018

:lgtm:


Reviewed 2 of 2 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@johlju johlju merged commit 8be0bfc into dsccommunity:dev Apr 21, 2018
@TraGicCode TraGicCode deleted the enable_code_cov branch April 21, 2018 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants