-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue where DSC configuration gets into a reboot loop because ses… #24
Conversation
…sionhost does not match (casing) and RDMS service is not started in time original issue/fix: https://gallery.technet.microsoft.com/scriptcenter/xRemoteDesktopSessionHost-4a11f27d/view/Discussions
Reviewed 1 of 1 files at r1. Comments from Reviewable |
Hi @KennethVerbeure apologies for the delay in looking at your PR, I've only recently become a maintainer, unfortunately a PR I just merged has created a conflict with your branch (#29), The change was purely style and formatting so should change anything directly relating to your PR. If your still interested in contributing to the module would you be able to update your PR and add an entry to the unreleased section on the README.md file please? |
Codecov Report
@@ Coverage Diff @@
## dev #24 +/- ##
=========================================
- Coverage 16.1% 15.96% -0.14%
=========================================
Files 5 5
Lines 118 119 +1
Branches 4 4
=========================================
Hits 19 19
- Misses 95 96 +1
Partials 4 4
Continue to review full report at Codecov.
|
Reviewed 1 of 1 files at r2, 1 of 1 files at r3. Comments from Reviewable |
@ld0614 i have no idea why now i got failing checks, all i did was merge with your DEV branch and edit the readme |
Hi @KennethVerbeure The checks are failing as part of my change I enabled codecoverage scoring. This repo is configured to fail a check if the code coverage score decreases and if your code has a lower test coverage than average (currently 16%). Unless someone specifically shoots me down (@kwirkykat) as the current unit testing state is so poor I'm ignoring them at the moment. My plan is to get at least a basic set of unit tests in place prior to enforcing these guidelines. |
@KennethVerbeure @ld0614 Yes you can completely ignore the 'failed' code coverage check for this repo |
Thanks for the Confirmation @kwirkykat and thanks @KennethVerbeure for the contribution |
Fix issue where DSC configuration gets into a reboot loop because sessionhost does not match (casing) and RDMS service is not started in time
original issue/fix: https://gallery.technet.microsoft.com/scriptcenter/xRemoteDesktopSessionHost-4a11f27d/view/Discussions
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)