Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where DSC configuration gets into a reboot loop because ses… #24

Merged
merged 3 commits into from
Nov 27, 2017

Conversation

KennethVerbeure
Copy link
Contributor

@KennethVerbeure KennethVerbeure commented Oct 18, 2017

Fix issue where DSC configuration gets into a reboot loop because sessionhost does not match (casing) and RDMS service is not started in time

original issue/fix: https://gallery.technet.microsoft.com/scriptcenter/xRemoteDesktopSessionHost-4a11f27d/view/Discussions


This change is Reviewable

@msftclas
Copy link

msftclas commented Oct 18, 2017

CLA assistant check
All CLA requirements met.

@ld0614
Copy link
Contributor

ld0614 commented Nov 13, 2017

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@ld0614 ld0614 added the waiting for author response The pull request is waiting for the author to respond to comments in the pull request. label Nov 22, 2017
@ld0614
Copy link
Contributor

ld0614 commented Nov 22, 2017

Hi @KennethVerbeure apologies for the delay in looking at your PR, I've only recently become a maintainer, unfortunately a PR I just merged has created a conflict with your branch (#29), The change was purely style and formatting so should change anything directly relating to your PR. If your still interested in contributing to the module would you be able to update your PR and add an entry to the unreleased section on the README.md file please?

@codecov-io
Copy link

codecov-io commented Nov 27, 2017

Codecov Report

Merging #24 into dev will decrease coverage by 0.13%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev      #24      +/-   ##
=========================================
- Coverage   16.1%   15.96%   -0.14%     
=========================================
  Files          5        5              
  Lines        118      119       +1     
  Branches       4        4              
=========================================
  Hits          19       19              
- Misses        95       96       +1     
  Partials       4        4
Impacted Files Coverage Δ
...RDSessionDeployment/MSFT_xRDSessionDeployment.psm1 18.75% <0%> (-1.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a6b79a...96ed2c0. Read the comment docs.

@ld0614
Copy link
Contributor

ld0614 commented Nov 27, 2017

:lgtm:


Reviewed 1 of 1 files at r2, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@ld0614 ld0614 removed the waiting for author response The pull request is waiting for the author to respond to comments in the pull request. label Nov 27, 2017
@KennethVerbeure
Copy link
Contributor Author

@ld0614 i have no idea why now i got failing checks, all i did was merge with your DEV branch and edit the readme

@ld0614
Copy link
Contributor

ld0614 commented Nov 27, 2017

Hi @KennethVerbeure The checks are failing as part of my change I enabled codecoverage scoring. This repo is configured to fail a check if the code coverage score decreases and if your code has a lower test coverage than average (currently 16%). Unless someone specifically shoots me down (@kwirkykat) as the current unit testing state is so poor I'm ignoring them at the moment. My plan is to get at least a basic set of unit tests in place prior to enforcing these guidelines.

@kwirkykat
Copy link
Contributor

@KennethVerbeure @ld0614 Yes you can completely ignore the 'failed' code coverage check for this repo

@ld0614 ld0614 merged commit 0188354 into dsccommunity:dev Nov 27, 2017
@ld0614
Copy link
Contributor

ld0614 commented Nov 27, 2017

Thanks for the Confirmation @kwirkykat and thanks @KennethVerbeure for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants