-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix false positive when another Collection exists #26
Conversation
The Test was passing when a Collection with a different name was present. Added CollectionName and ConnectionBroker to Get-TargetResource (which is referenced by Test-TargetResource) to prevent the test from passing when a Collection with a different name exists.
Microsoft Contribution Licensing Agreement (CLA) has been signed |
Hi @RobBiddle Thanks for the PRs, would you be able to update the readme for this change please as it could impact existing builds which rely on this 'feature'. Notes here |
Unreleased changes updated
Thanks for the update @RobBiddle, I noticed that you've created issues to associate with these PRs, would you just be able to append to the title of the PRs to state that they fix the associated issue please? Sorry if my above comment gave the wrong impression, I don't believe that this change would be classed as a breaking change as it doesn't meet the bar set here, I think something nice and succinct such as 'Fixed an issue where xRDSessionCollection would return true if any collection existed' would suffice, Happy to discuss further 😃 |
Apologies @RobBiddle a PR I mergedwhich basically resolved a lot of PSSA issues (#29) with the module is now causing a conflict with your PR. Functionally the PR didn't change anything it just updated some of the formatting and style. |
Labeling this PR as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on the PR is taken up again. |
The Test was passing when a Collection with a different name was present.
Added CollectionName and ConnectionBroker to Get-TargetResource (which is referenced by Test-TargetResource) to prevent the test from passing when a Collection with a different name exists.
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)