Fixes issue with readOnly property #196
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JsonSchema specifies that the readOnly property be camel-case, so we need to map that over to the lower case javascript property that is used internally.
|
Can you submit this PR against https://github.com/shamoons/ng-json-schema-form It seems this package is no longer maintained so I'm forking and plan to maintain it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JsonSchema specifies that the readOnly
property be camel-case, so we need to
map that over to the lower case javascript
property that is used internally.
PR Type
What changes does this PR include (check all that apply)?
[x ] Bugfix
Related issue / current behavior
When setting the readOnly property in JsonSchema, the value is ignored unless you specify it in lowercase. The spec defines the attribute to be lower camel-cased.
New behavior
readOnly properties are now properly mapped over to the internal lowercased name.
Does this PR introduce a breaking change?
[ ] Yes
[x ] No