Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix #204) move fxLayoutWrap to fxLayout #230

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

j2L4e
Copy link

@j2L4e j2L4e commented Mar 13, 2018

@j2L4e j2L4e changed the title move fxLayoutWrap to fxLayout (fix #204) move fxLayoutWrap to fxLayout Mar 13, 2018
@sasos90
Copy link

sasos90 commented Mar 16, 2018

Please merge this ASAP... this will save prod build.

@Theyssen
Copy link

Please merge this. We need the production build to work.

@lbispham
Copy link

The entire library is not working for me because of this issue

@Koslun
Copy link

Koslun commented Mar 26, 2018

These changes should still work in some earlier beta version of flex-layout but can't find which specific version from reading the changelog: https://github.com/angular/flex-layout/blob/master/CHANGELOG.md

If any change remains I think it'd be to be more specific in the peer-dependency on which beta version this works. I.e. changing this line: https://github.com/dschnelldavis/angular2-json-schema-form/blob/master/package.json#L65.

Agree that this should be a high-priority to merge though.

@j2L4e
Copy link
Author

j2L4e commented Mar 26, 2018

It still works with any version < beta 13

@DhiaEddineSaidi
Copy link

Please merge this. We need AOT compilation to work.

@DhiaEddineSaidi
Copy link

I confirm these commits , Please merge.

@Theyssen
Copy link

One more time: Please Merge this. We need this badly.

@sasos90
Copy link

sasos90 commented Apr 23, 2018

I think I will make a fork of this repo and give you the reference and merge it in my repo. But I will wait for few days now if they react.

@rhalff
Copy link
Contributor

rhalff commented Apr 23, 2018

I have an update angular 5 branch here: https://github.com/rhalff/angular2-json-schema-form/tree/angular-5

And a angular 6 one over here: https://github.com/rhalff/angular2-json-schema-form/tree/angular-6

This patch has been merged and some other material updates. Both are able to build and serve the demo app without errors.

I have no intention to permanently fork, but a few projects I've created are using this super useful library :-)

If you want to use the branch, you could fork to your own repository and then:

  • npm i
  • npm run deploy

Deploy will push to your repo and create an angular-(5/6)-dist branch

Then in the application consuming the library:
npm install <your-repo>/angular2-json-schema-form#angular-5-dist --save or #angular-6-dist

The builds do not solve the forRoot() problem as described in angular/angular#14707, you'll still have to do that manually.

Note: seems like yarn doesn't understand pointing a dependency to a branch on github: yarnpkg/yarn#3720 so you must use npm to install.

@Koslun
Copy link

Koslun commented May 5, 2018

@rhalff Nice work. Forked your fork and hooked it up to a fresh angular 6 example app where I verified that it compiled with latest angular, angular material and flex-layout: https://github.com/Koslun/ng-example-app/tree/feat/ng6-angular2-json-schema-form.

The placeholder for the input elements for MaterialDesign however still don't float, making any placeholder merge with the text you write in the input. So still can't really use MaterialDesign as-is.

Used hack from #189 (comment) to manually fix the forRoot() issue, adding this to the @NgModule imports array:

    NoFrameworkModule,
    {
      ngModule: JsonSchemaFormModule,
      providers: [
        JsonSchemaFormService,
        FrameworkLibraryService,
        WidgetLibraryService,
        { provide: Framework, useClass: NoFramework, multi: true },
      ],
    },

Easier to just have choose one import for each of the different options as you can't use multiple ones or choose to skip using one of them. So maybe instead choose among:

  • JsonSchemaFormNoFrameworkModule,
  • JsonSchemaFormMaterialModule,
  • JsonSchemaFormBootstrap3Module,
  • JsonSchemaFormBootstrapModule,

@VirusDEAD
Copy link

I did something like this. No need to provide NoFramework if you plan to use one


Bootstrap4FrameworkModule,
    {
      ngModule: JsonSchemaFormModule,
      providers: [
        JsonSchemaFormService, FrameworkLibraryService, WidgetLibraryService,
        Bootstrap4FrameworkModule.forRoot().providers[0]
      ]
    },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fxLayoutWrap no longer exists
8 participants