Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper Internalisation support for text #83

Closed
fliptrail opened this issue Mar 31, 2019 · 2 comments
Closed

Add proper Internalisation support for text #83

fliptrail opened this issue Mar 31, 2019 · 2 comments
Labels
Beginner Pro It is for those who have completed few android courses of udacity enhancement New feature or request

Comments

@fliptrail
Copy link
Contributor

I suggest that there should be proper internationalisation support to enable multiple languages. Over the course of time, I have realized that the sooner all the text gets internationalised the better it is.

References: https://developer.android.com/guide/topics/resources/localization, https://lingohub.com/frameworks-file-formats/android-i18n-android-studio/

I suggest that this would be very helpful in scaling up the app.

PS: if it still not your priority right now, feel free to close this issue.

Would you like to work on the issue?

No

@fliptrail fliptrail added enhancement New feature or request Beginner Pro It is for those who have completed few android courses of udacity Urgent Need to be solved very quickly labels Mar 31, 2019
@amangrobo
Copy link
Member

It's already done, the strings are being loaded from a separate file and are nor being hardcoded(except a few cases, which will be corrected soon). I have also added a few words in the Hindi language yet.

@fliptrail
Copy link
Contributor Author

It's already done, the strings are being loaded from a separate file and are nor being hardcoded(except a few cases, which will be corrected soon). I have also added a few words in the Hindi language yet.

Feel free to close this, when it is done

@atm1504 atm1504 removed the Urgent Need to be solved very quickly label Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Beginner Pro It is for those who have completed few android courses of udacity enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants