Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added CA Page #106

Merged
merged 3 commits into from
Oct 20, 2023
Merged

feat: added CA Page #106

merged 3 commits into from
Oct 20, 2023

Conversation

jayeshxn
Copy link
Member

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your default branch!
  • Make sure you are making a pull request against the default branch (left side). Also you should start your branch off default branch.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.
  • I have added necessary documentation (if appropriate)

Description

Please describe your pull request.

❤️Thank you!

Post merge checklist

  • Follow steps from the guidelines for contributing to this repository.
  • If you are a new contributor, ping in the thread and one of the maintainers will add you to all-contributors list.

@netlify
Copy link

netlify bot commented Oct 20, 2023 •
edited
Loading

✅ Deploy Preview for innowebsite ready!

Name Link
🔨 Latest commit 055b8bd
🔍 Latest deploy log https://app.netlify.com/sites/innowebsite/deploys/6532d1680e4be40008a718ce
😎 Deploy Preview https://deploy-preview-106--innowebsite.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jayeshxn
Copy link
Member Author

@Shurtu-gal Please Review

Shurtu-gal
Shurtu-gal requested changes Oct 20, 2023
View reviewed changes
src/pages/ca.js Outdated
import { PrivateRoute } from '../components';

const CA = () => (
<PrivateRoute>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think privateRoute is required here as logon is not necessary to access the page.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is mentioned as part of CA Registration process, that one needs to be logged in before CA Registration

src/pages/ca.js Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: The page name can be changed. https://inno.nitrkl.in/ca doesn't look good. 🤪

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any suggestions?

Shurtu-gal
Shurtu-gal approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@Shurtu-gal Shurtu-gal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤖

@Shurtu-gal Shurtu-gal merged commit 0e16d9c into dscnitrourkela:main Oct 20, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shurtu-gal Shurtu-gal Shurtu-gal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jayeshxn @Shurtu-gal