Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the color theme in the tailwind.config.js #32

Merged
merged 2 commits into from
Oct 8, 2022

Conversation

mohammadshaad
Copy link
Contributor

πŸ› οΈ Fixes Issue

πŸ‘¨β€πŸ’» Changes proposed

I have added the color theme for the website in the tailwind.config.js file. This color theme is the same color theme used in Google's or GDSC's official website.

πŸ”§ Check List (Check the type of issue it fixes)

  • Bug Fix
  • New Extension
  • Enhancement
  • Documentation

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have done git pull before adding my new changes
  • The title of my pull request is a short description of the requested changes.

πŸ“„ Note to reviewers

I have searched for the color scheme and found these colors. Kindly review and merge the PR. Attaching the screenshots of the code and color pallete.

πŸ“· Screenshots

image

image

@vercel
Copy link

vercel bot commented Oct 8, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
dscvitchennai βœ… Ready (Inspect) Visit Preview Oct 8, 2022 at 2:46PM (UTC)

@mohammadshaad
Copy link
Contributor Author

@Arjun31415 I have made the PR properly but don't know why this Prettier Formatting Check error is coming can you please guide me is this from my end or github? Thank you

@@ -6,6 +6,16 @@ module.exports = {
],
theme: {
extend: {},
colors: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have to put it in colours, why not extend the colours with the original colours provided by tailwind theme so that we can use the preexisting ones

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay so I should put the colors object inside the extend only am I right?

@Arjun31415
Copy link
Contributor

@Arjun31415 I have made the PR properly but don't know why this Prettier Formatting Check error is coming can you please guide me is this from my end or github? Thank you

I will look into this,but please format your code using prettier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants