Previous documentation defined booleans as yes or no (ansible-com…

…munity/community-topics#116).  This was changed in ansible/ansible#78921 to use `true` or `false`.

Do not use release candidates or alpha releases in Jenkinsfiles

README.md

@@ -13,7 +13,7 @@ This is run as an Ansible lookup:
       hostname: "{{ esxi_ip }}"
       username: "{{ esxi_username }}"
       password: "{{ esxi_password }}"
-      validate_certs: False
+      validate_certs: false
       hostnames: ['config.name']
       keyed_groups: []
 
@@ -32,7 +32,7 @@ This is run as an Ansible lookup:
       aws_access_key: "{{ aws_access_key }}"
       aws_secret_key: "{{ aws_secret_key }}"
       region: "{{ region }}"
-      validate_certs: False
+      validate_certs: false
       keyed_groups: []
 
 - name: Get proxmox inventory info
@@ -43,6 +43,6 @@ This is run as an Ansible lookup:
       url: "https://192.168.1.70:8006"
       user: root@pam
       password: 'PASSWD'
-      validate_certs: False
-      want_facts: yes
+      validate_certs: false
+      want_facts: true
 ```

jenkinsfiles/Jenkinsfile_release_tag

@@ -5,7 +5,7 @@ def PROJECT_URL_DEFAULT = "https://github.com/dseeley/inventory_lookup"
 def PROJECT_BRANCH_DEFAULT = "master"       //Set the default git branch to use if we're not running an SCM job (e.g. if we're copying/pasting into a pipeline script)
 
 def pypi_ansible = ["curl", "-s", "-H", "Accept: application/json", "-H", "Content-type: application/json", "GET", "https://pypi.org/pypi/ansible/json"].execute().text
-def pypi_ansible_latest = new groovy.json.JsonSlurper().parseText(pypi_ansible).releases.keySet()[-1]
+def pypi_ansible_latest = new groovy.json.JsonSlurper().parseText(pypi_ansible).info.version        // Use `info.version` instead of `.releases.keySet()[-1]`, to avoid alpha and release candidate versions
 
 //This allows us to create our own Docker image for this specific use-case.  Once it is built, it will not be rebuilt, so only adds delay the first time we use it.
 def create_custom_image(image_name, build_opts = "") {

jenkinsfiles/Jenkinsfile_release_tag__auto

@@ -1,7 +1,7 @@
 #!groovy
 
 def pypi_ansible = ["curl", "-s", "-H", "Accept: application/json", "-H", "Content-type: application/json", "GET", "https://pypi.org/pypi/ansible/json"].execute().text
-def pypi_ansible_latest = new groovy.json.JsonSlurper().parseText(pypi_ansible).releases.keySet()[-1]
+def pypi_ansible_latest = new groovy.json.JsonSlurper().parseText(pypi_ansible).info.version        // Use `info.version` instead of `.releases.keySet()[-1]`, to avoid alpha and release candidate versions
 
 node {
     stage('Call ansible/inventory_lookup-release-tag') {

plugins/lookup/inventory.py

@@ -28,7 +28,7 @@
       hostname: "{{ esxi_ip }}"
       username: "{{ esxi_username }}"
       password: "{{ esxi_password }}"
-      validate_certs: False
+      validate_certs: false
       hostnames: ['config.name']
       keyed_groups: []
 
@@ -47,7 +47,7 @@
       aws_access_key: "{{ aws_access_key }}"
       aws_secret_key: "{{ aws_secret_key }}"
       region: "{{ region }}"
-      validate_certs: False
+      validate_certs: false
       keyed_groups: []
 
 - name: Get proxmox inventory info
@@ -58,8 +58,8 @@
       url: "https://192.168.1.70:8006"
       user: root@pam
       password: 'PASSWD'
-      validate_certs: False
-      want_facts: yes
+      validate_certs: false
+      want_facts: true
 """
 
 from ansible.errors import AnsibleOptionsError