Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] yticklabels in plots.waterfall() #58

Merged
merged 1 commit into from May 22, 2023

Conversation

dwolfeu
Copy link

@dwolfeu dwolfeu commented May 22, 2023

This allows for cases where the type of features[order[i]] is incompatible with string addition, e.g. boolean type.

@dwolfeu dwolfeu changed the title [BUGFIX] yticklabels in plots.waterfall() [BUGFIX] yticklabels in plots.waterfall() May 22, 2023
@connortann
Copy link
Collaborator

Looks good to me - thank you for the PR @dwolfeu !

@thatlittleboy
Copy link
Collaborator

thatlittleboy commented May 22, 2023

Port of slundberg#2912. The changes are small and straightforward, merging! Thanks!

@thatlittleboy thatlittleboy merged commit 383ca03 into dsgibbons:master May 22, 2023
1 of 5 checks passed
@dwolfeu dwolfeu deleted the waterfall_plot branch May 22, 2023 10:30
This was referenced May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants