Fix further NumbaDeprecationWarnings: migrate from jit to njit #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connortann
changed the title
|
On the previous PR, I didn't check that the warnings were fixed on python 3.10. Checking the logs of this PR, those warnings seem to be properly fixed now. The only Numba warnings that remain relate to deprecated types; I opened a separate issue for that: #70. |
|
@dsgibbons would you be able to review? The numba warnings seem to be of relatively high interest judging by the traffic, so it would be fab to get this issue fixed fully. |
dsgibbons
approved these changes
May 25, 2023
There was a problem hiding this comment.
@connortann thank you for bringing the increased traffic to my attention. I read over https://numba.readthedocs.io/en/stable/reference/deprecation.html as I was not too familiar with njit. Your PR looks good and it doesn't seem to have broken any tests that were broken before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue: shap#2909
PR #9 attempted to solve the issue by explicitly specifying
nopython=False, but inadvertently introduced other Deprecation warnings asnopythonmode is being removed entirely.The recommendation from numba is to disable the object mode behaviour, by setting
nopython=Trueor equivalently usingnjit.