Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Custom Taxonomy with Dynamic Hierarchy #200

Closed
kartguru opened this issue Oct 27, 2020 · 9 comments
Closed

Feature Request: Custom Taxonomy with Dynamic Hierarchy #200

kartguru opened this issue Oct 27, 2020 · 9 comments

Comments

@kartguru
Copy link

Use geo_address to create categories in a logical hierarchy, i.e. Country > Region > City. This allows for filtering based on a custom taxonomy, an alternative way to display posts to the map based layouts.

Potentially optional levels if going as granular as #198 suggests (i.e. https://github.com/predicthq/address-formatter-php)

Thanks for considering and kudos on the simple yet effective plugin

@dshanske
Copy link
Owner

Related #40

@dshanske
Copy link
Owner

Properties would be http://microformats.org/wiki/h-adr

@dshanske
Copy link
Owner

Same names used by various services

@kartguru
Copy link
Author

definitely a standard format

@dshanske
Copy link
Owner

dshanske commented Feb 7, 2021

Little different than requested....but done.

@dshanske dshanske closed this as completed Feb 7, 2021
@kartguru
Copy link
Author

your 'little different' makes a lot of sense @dshanske. The interpretation/implementation is slick, thats for sure. thanks for following up with my suggestion.

The issue I've come across so far is that the terms are not selected upon updating the post. I had to manually do so after setting 'show_in_rest' or 'show_in_quick_edit' to true. I think you have set as false as your plugin is doing all the hardwork (which makes sense), its just not selected at the moment.

apart from that its awesome. the Country, Region, Locality breakdown is really nice.

@dshanske
Copy link
Owner

It's to prevent selecting multiple terms as it should be only one per post. The JS should set it automatically. I'll look into why it might not be. I released a series of updates this week to refine the feature after deployment. I still want to add a few more, such as a front end landing page that shows all terms and a term merge capability.

@kartguru
Copy link
Author

hey @dshanske, just some more feedback from testing this new feature.

I had two examples of localities not becoming children of regions when region existed.

It seemed to function as expected when a new region and locality were added to a pre-existing country.

will let you know if i see any other querky stuff. cheers

@dshanske
Copy link
Owner

I'm doing some additional unit testing now on this. I found a scenario already I fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants