Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean Up and Prettyify Location Metabox #57

Merged
merged 19 commits into from
Jan 24, 2018
Merged

Clean Up and Prettyify Location Metabox #57

merged 19 commits into from
Jan 24, 2018

Conversation

kingkool68
Copy link

@kingkool68 kingkool68 commented Jan 21, 2018 •
edited

👋 David!

Before:
screen shot 2018-01-21 at 3 15 44 pm

After:
screen shot 2018-01-21 at 3 15 23 pm

  • Refactored and linted location.js
  • Cleaned up the form markup and grouped like-items together better
  • Added some pseudo-grid CSS classes to better align the fields to make them more visually pleasing
  • Replaced the icons with actual buttons that make clear what the action does
  • Add a confirmation before clearing location data (a destructive behavior)
  • Add a loading spinner while we wait to fetch geo data so things don't look broken

@kingkool68
Fix JavaScript location paths
82dc8f2 
If the directory name changes, the scripts will break. Using `dirname(__FILE__)` will get the parent directory of the script currently being executed.
@kingkool68
Linting.
0f397e9
@kingkool68
Move functions within a single jQuery ready() call
fc31794 
Now we don't need to spell out `jQuery` every time. We can just use the shorthand `$`.
@kingkool68
Chain $( document ).on() calls
b8326f8 
Slight refactor to put initialization code after function definitons.
@kingkool68
Use a loop to clear lcoation fields.
f3a8db9 
Less code to write.
@kingkool68
Remove inline JavaScript event.
b9b264b 
Handle this with an onclick method in jQuery instead.
@kingkool68
Linting errors.
3b5dbd2
@kingkool68
Move event.preventDefault() calls to the end of the event handler fun…
73279be 
…ctions.

If there is some sort of error then the default event action (follow a link etc.) will occur instead of being broken.
@kingkool68
Make sure the console object exists before calling it.
4a42a28 
Otherwise the AJAX request will fail. Probably could remove the `console` statement all together.
@kingkool68
Use a button to get your current location.
1aedfdc
@kingkool68
Hidden fields don't need a style attribute set.
5656abb 
I don't think we need to worry about the map zoom.
@kingkool68
Enqueue a stylesheet for the Location metabox.
94f884c
@kingkool68
Move location details around.
39be9ae
@kingkool68
Confrim we actually want to rest location data.
020921f
@kingkool68
Cleaning up some form markup.
c246e23
@kingkool68
Add a loading spinner.
700944f 
Just so we know the computer is doing something and not just sitting idle.
@kingkool68
Form field prettying and tidying up is complete.
060736f 
Use better markup and pseduo grid CSS classes.
@dshanske
Copy link
Owner

Can you fix the style issue that makes it fail phpcs validation?

@dshanske dshanske changed the base branch from master to pretty January 24, 2018 13:27
@dshanske
Copy link
Owner

Merging this into a branch to play with and do some other things before merging it into Master.

@dshanske dshanske merged commit 5ac0221 into dshanske:pretty Jan 24, 2018
@dshanske
Copy link
Owner

I'm going to do some additional work on this. I've decide I want to move the metabox code into its own file. It is getting way too long to be with everything else. It will be easier to maintain going forward if I separate it out.

@dshanske
Copy link
Owner

Continuing to work on this. Trying to get the improvements, but return to a view with less height.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kingkool68 @dshanske