Refactor so that plugins can always add their own URLs at runtime. #3
Conversation
This commit refactors the `get_syndication_links()` function in order to ensure that the `syn_add_links` filter is always processed. Prior to this commit, the filter was only processed if the `syndication_urls` post meta field was non-empty, which meant that plugins were unable to modify the `$urls` array that contained POSSE syndication addresses unless a prior syndication URL already existed. But this constraint made the plugin mostly useless for auto-crossposting plugins that wanted to automate the process of adding syndication links to crossposted entries. This commit also cleans up mixed spaces and tabs. :\
Refactor so that plugins can always add their own URLs at runtime.
|
Happy to merge this. I went through a lot of revisions prior to deploying this to the repository. I tried specifying the types of networks initially, but changing to a list of URLs actually made things easier for everyone. Then I was going to write code to have plugins copy their data into the right key, but realized that would mean a lot of support I didn't need to have. As for the mixed spaces and tabs...I know, people keep telling me. I have to break that habit. I've been working on it. |
/me preaches Vim it up, my friend! :D See also 7 Habits of Highly Effective Text Editing. Anyways, thanks for merging this so quickly. :) |
If a user creates, but then deletes a syndication link, this refactored code will always return an array that begins with an empty string as the first element, because that's how WordPress saves the "Syndication Links" meta field when it's empty. This commit guards against creating an empty list item in the list of syndicated links. Probably should have put this in pull request dshanske#3 but I did not test thoroughly enough, obvs.
|
Oopsies, found a small issue with this in my testing, so I have a new defensive code commit e05f420. This could probably also be addressed by modifying the meta field's save handler, but guarding against empty strings here seems both simpler and more robust. Sorry for not including this in the original commit. |
This commit refactors the
get_syndication_links()function in order toensure that the
syn_add_linksfilter is always processed. Prior tothis commit, the filter was only processed if the
syndication_urlspost meta field was non-empty, which meant that plugins were unable to
modify the
$urlsarray that contained POSSE syndication addressesunless a prior syndication URL already existed. But this constraint made
the plugin mostly useless for auto-crossposting plugins that wanted to
automate the process of adding syndication links to crossposted entries.
This commit also cleans up mixed spaces and tabs. :\