Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare the 0.3.0 release. #8

Merged
merged 2 commits into from
Apr 15, 2016
Merged

Prepare the 0.3.0 release. #8

merged 2 commits into from
Apr 15, 2016

Conversation

yallop
Copy link
Collaborator

@yallop yallop commented Apr 13, 2016

No description provided.

@dsheets
Copy link
Owner

dsheets commented Apr 14, 2016

This may need some more changelog entries?

@yallop
Copy link
Collaborator Author

yallop commented Apr 15, 2016

What do you have in mind?

@dsheets
Copy link
Owner

dsheets commented Apr 15, 2016

Fcntl_unix, Fcntl_unix_lwt? Maybe we should call Fcntl_unix_lwt just Fcntl_lwt because the data types and conversions alone will never have reason to use lwt without a system for I/O?

@yallop
Copy link
Collaborator Author

yallop commented Apr 15, 2016

Fcntl_unix was in 0.2.0. The lwt binding is already mentioned, but I'll add a reference to the module.

I don't have strong views about the name Fcntl_unix_lwt. I think the _unix_lwt suffix indicates that it's more closely related to Fcntl_unix than to Fcntl, and that it won't be available on non-Unix systems, even those (such as js_of_ocaml) that support lwt, but I'll rename it if you prefer; let me know either way.

@dsheets
Copy link
Owner

dsheets commented Apr 15, 2016

No, that all makes sense, thanks!

@dsheets dsheets merged commit a464545 into dsheets:master Apr 15, 2016
@yallop yallop deleted the prepare-0.3.0 branch April 15, 2016 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants