fix: PathRef#withExtname should allow setting no extension (#199)

dsherret · Dec 17, 2023 · 0c7dc79 · 0c7dc79
1 parent a41ffe6
commit 0c7dc79
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/path.test.ts b/src/path.test.ts
@@ -278,6 +278,12 @@ Deno.test("withExtname", () => {
   path = path.withExtname(".txt");
   assertEquals(path.basename(), "other.txt");
   assertEquals(path.extname(), ".txt");
+  path = path.withExtname("");
+  assertEquals(path.basename(), "other");
+  assertEquals(path.extname(), undefined);
+  path = path.withExtname("txt");
+  assertEquals(path.basename(), "other.txt");
+  assertEquals(path.extname(), ".txt");
 });
 
 Deno.test("withBasename", () => {

diff --git a/src/path.ts b/src/path.ts
@@ -380,7 +380,7 @@ export class PathRef {
   withExtname(ext: string): PathRef {
     const currentExt = this.extname();
     const hasLeadingPeriod = ext.charCodeAt(0) === PERIOD_CHAR_CODE;
-    if (!hasLeadingPeriod) {
+    if (!hasLeadingPeriod && ext.length !== 0) {
       ext = "." + ext;
     }
     return new PathRef(this.#path.substring(0, this.#path.length - (currentExt?.length ?? 0)) + ext);