Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: inherit by default for stdout and stderr #18

Merged
merged 2 commits into from Aug 28, 2022
Merged

Conversation

dsherret
Copy link
Owner

This changes stdout and stderr to be inherited by default. There are several reasons for doing this:

  1. It's more efficient.
  2. I find myself writing a lot of commands without needing to capture the majority of the time.
  3. There are now helper methods like const text = await `some_command`.text(), which will automatically capture when necessary and people should prefer using those.
  4. Helps keep stdout and stderr printed in order (Text written to piped stdout/stderr is printed out of order #17)

@dsherret dsherret merged commit c3feef8 into main Aug 28, 2022
@dsherret dsherret deleted the inherit_stdout_stderr branch August 28, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant