Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: escapeArg was not escaping multiple quotes #194

Merged
merged 4 commits into from Dec 17, 2023
Merged

fix: escapeArg was not escaping multiple quotes #194

merged 4 commits into from Dec 17, 2023

Conversation

Ryooooooga
Copy link
Contributor 

import $ from "https://deno.land/x/dax/mod.ts";
import $2 from "./mod.ts"; // this branch

await $2`echo ${`'abc'`}`; // 'abc'
await $`echo ${`'abc'`}`; // error: Uncaught "Expected closing single quote.\n  '\n  ~"

dsherret
dsherret reviewed Dec 17, 2023
View reviewed changes
src/command.ts
return arg;
} else {
return `'${arg.replace("'", `'"'"'`)}'`;
return `'${arg.replaceAll("'", `'"'"'`)}'`;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Classic. Thanks!

@dsherret dsherret changed the title fix escapeArg fix: escapeArg was not escaping multiple quotes Dec 17, 2023
@dsherret dsherret merged commit e0386dd into dsherret:main Dec 17, 2023
3 checks passed
@Ryooooooga Ryooooooga deleted the fix/escape-arg branch December 18, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ryooooooga @dsherret