Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: clearEnv on CommandBuilder #264

Merged
merged 3 commits into from
May 4, 2024
Merged

feat: clearEnv on CommandBuilder #264

merged 3 commits into from
May 4, 2024

Conversation

Yohe-Am
Copy link
Contributor

@Yohe-Am Yohe-Am commented Apr 10, 2024

Solves #63.

Interplay between clearEnv and exportEnv proves tricky. I've went with a solution that, when both flags are set:

  • Writes to the env will go through and affect the real env.
  • Reads will not access any values acquired from the ambient environment.

@Yohe-Am Yohe-Am mentioned this pull request Apr 30, 2024
Merged
3 tasks
@zifeo
Copy link

zifeo commented Apr 30, 2024

@dsherret Could this be reviewed? This support would help us to move forward with dax.

@dsherret dsherret self-requested a review April 30, 2024 16:56
@Yohe-Am Yohe-Am mentioned this pull request Apr 30, 2024
Closed
dsherret
dsherret approved these changes May 4, 2024
View reviewed changes
Copy link
Owner

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dsherret dsherret merged commit 48f4ebe into dsherret:main May 4, 2024
3 checks passed
@dsherret dsherret mentioned this pull request May 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Yohe-Am @zifeo @dsherret