feat: Add copy/move commands #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The deno std join doesn't join absolute path with common prefix correctly, I think rust one is more intuitive |
dsherret
reviewed
Dec 4, 2022
src/common.ts
Outdated
| rustjoin("/a/b","/a/c") => "/a/b/c" | ||
|
|
||
| instead of: | ||
| Deno.path.join("/a/b","/a/c") => "/a/b/a/c" |
There was a problem hiding this comment.
Ummm... weird. Seems like Deno is copying what node does with fs.path.
src/commands/cp_mv.ts
Outdated
| // They only exists to give better error messages. | ||
| if (await isDir(from.path)) { | ||
| if (flags.recursive) { | ||
| if (await fs.exists(to.path) && await isFile(to.path)) { |
There was a problem hiding this comment.
Instead of calling fs.exists here, we could just call Deno.lstat once.
|
I have to head out soon, so I'll probably look at this more later tonight or tomorrow. Thanks a lot for all the PRs! |
|
Sure thanks as well! |
|
I'm updating this PR just now with main. Give me a few minutes.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.